78149[BUFGIX] Instanciate individual objects of StandaloneView
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Stefan Froemken uploaded patch set 1 03/17/23, 13:35
-
core-ci voted on patch set 1 V +1 03/17/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39128
-
Oliver Klee voted on patch set 1 CR +1 03/17/23, 13:55
-
Nikita Hovratov commented on patch set 1 CR +1 03/17/23, 14:09
Eventhough I would highly recommend not to inject prototype classes, this really seems to be forgotten. -
Stefan Froemken commented on patch set 1 03/17/23, 15:25
Reply
I have changed that already in one of my extensions. So I don't really need that patch anymore, but for compatibility we should take care of. As you see the TemplateView is configured the same way. -
Stefan Bürk commented on patch set 1 V +1 CR +1 03/18/23, 10:42
Reply
This does not fully mitigate a breaking behaviour, even if it is now not shared anymore. Before v12 StandAloneView instantiated a blank extbase request in the constructor, which is not done any longer (thanks to lolli to remove that). So you have to take care to set a proper request if needed in your templates etc. It's better to design a factory which is injected in your extension anyway. And properly set the request/request with extbase arguments to it etc. -
Nikita Hovratov voted on patch set 1 V +2 CR +2 03/18/23, 11:16
-
Nikita Hovratov merged patch set 2 03/18/23, 11:16