Review 11.5 Abandoned

78151[BUGFIX] check all hidden conditions for a page

TYPO3com CR 0 V 0 Easy +2 −5 updated 07/12/24, 21:01

Commit message

if i time a page, and the page is not displayed anymore, the return code
is 403 but i think it should be 404. there is a ticket
https://forge.typo3.org/issues/86346 where the case was fixed for the
hidden field, but it ignores the start/endtime case.

If we use getPage instead of getPage_noCheck the start and end time is
checked and the handling should be correct.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 47

  1. TYPO3com uploaded patch set 1 03/17/23, 14:01

  2. core-ci voted on patch set 1 V -1 03/17/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39132

  3. Benni Mack commented on patch set 1 03/17/23, 19:51

    TypoScriptFrontendController.php:1095 Unresolved

    if we do this, we can throw away the code below... $requestedPageIsHidden = (bool)$rawPageRecord[$hiddenField]; It will never be hidden then ;)
  4. Kalle Karlson commented on patch set 2 V -1 03/20/23, 14:58

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V -1 03/20/23, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39248

  6. Benni Mack updated the commit message in patch set 3 V -1 05/03/23, 09:54

  7. Benni Mack abandoned the change 07/12/24, 21:01

    abandoning this change due to lack of feedback