Review main Merged

78155[TASK] LiveSearch: Extract handling into repository

Andreas Kienast CR +2 V +2 Normal +104 −41 updated 03/22/23, 15:31

Commit message

To make the LiveSearch API usable in different contexts (e.g. the
record list), the common search handling is extracted into a repository
class, which is now used in the `LiveSearchController`.

In a further iteration, pagination will be added to the repository
class.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Andreas Kienast uploaded patch set 1 03/17/23, 15:31

  2. Andreas Kienast uploaded patch set 2 03/17/23, 15:33

  3. core-ci voted on patch set 2 V +1 03/17/23, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39142

  4. core-ci voted on patch set 1 V +1 03/17/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39141

  5. Benni Mack commented on patch set 2 03/17/23, 19:51

    SearchService.php:31

    sounds more like a SearchProviderRepository? :)
  6. Andreas Kienast commented on patch set 2 03/17/23, 20:18

    SearchService.php:31 Reply

    Hmm, not sure 🙃
  7. Andreas Kienast uploaded patch set 3 V +1 03/19/23, 11:34

  8. Andreas Kienast commented on patch set 3 03/19/23, 11:35

    SearchService.php:31 Reply

    Done
  9. core-ci voted on patch set 3 V +1 03/19/23, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39201

  10. Georg Ringer voted on patch set 3 CR +1 03/19/23, 14:02

  11. Benni Mack voted on patch set 3 CR +1 03/21/23, 15:51

  12. Benni Mack voted on patch set 3 V +1 03/22/23, 11:27

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 03/22/23, 15:31

  14. Andreas Kienast merged patch set 4 03/22/23, 15:31