78158[BUGFIX] Prevent type error in TypoLinkViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Serfhos +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Serfhos +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Benjamin Serfhos uploaded patch set 1 03/17/23, 16:33
-
core-ci voted on patch set 1 V +1 03/17/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39148
-
Oliver Klee commented on patch set 1 03/17/23, 18:35
The 12.3 branch usually does not receive bugfixes. Do you mean 11.5? -
Oliver Klee commented on patch set 1 03/17/23, 19:17
I’d recommend a commit message title that says more about the “why” or the change. What do you think of this? [BUGFIX] Prevent type error in TypoLinkViewHelper -
Benjamin Serfhos updated the commit message in patch set 2
V +103/20/23, 15:44 -
Benjamin Serfhos commented on patch set 2 03/20/23, 15:45
Reply
ChangedReply
No, this bug is introduced by TYPO3 12 and can affect current development flow, no 11 backport is required -
Oliver Klee voted on patch set 2 CR +1 03/20/23, 15:49
-
Oliver Klee updated the commit message in patch set 3
CR +103/20/23, 15:50 -
Oliver Klee voted on patch set 3 CR +1 03/20/23, 15:50
-
core-ci voted on patch set 3 V +1 03/20/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39255
-
core-ci voted on patch set 2 V +1 03/20/23, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39254
-
Benjamin Serfhos voted on patch set 3 V +1 CR +1 03/20/23, 17:39
-
Benni Mack voted on patch set 3 V +2 CR +2 03/20/23, 21:52
-
Benni Mack merged patch set 4 03/20/23, 21:52