Review main Abandoned

78160[BUGFIX] Regenerate uuid on copy record

Jochen Roth CR 0 V 0 Easy +28 −5 updated 11/23/23, 21:21

Commit message

The extension 'reactions' throws an undefined array key
warning when a record is copied using the context menu or
the "paste in" in the doc header.

This has been fixed by regenerating the uuid for all fields
using TCA type uuid in the datahandler.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3344

Show 1319 earlier messages
  1. Jochen Roth uploaded patch set 1 03/17/23, 17:28

  2. core-ci voted on patch set 1 V -1 03/17/23, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39153

  3. Jochen Roth uploaded patch set 2 V -1 03/17/23, 18:06

  4. core-ci voted on patch set 2 V +1 03/17/23, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39154

  5. Benni Mack updated the commit message in patch set 3 V +1 03/17/23, 19:50

  6. core-ci voted on patch set 3 V +1 03/17/23, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39155

  7. Jochen Roth updated the commit message in patch set 4 V +1 03/17/23, 20:09

  8. Oli Bartsch commented on patch set 4 03/17/23, 20:13

    DataHandler.php:3578

    calling a „checkValue“ method feels wrong here. could be move the necessary code in a protected function an call it at those places?

    sys_reaction.php:84

    This is the default and does not need to be defined.
  9. core-ci voted on patch set 4 V +1 03/17/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39156

  10. Jochen Roth commented on patch set 4 03/17/23, 20:56

    Removed the required and added a getNewUuid method instead of misusing the other method. Thank you :-)

    DataHandler.php:3578 Reply

    Done

    sys_reaction.php:84 Reply

    Ack
  11. Jochen Roth uploaded patch set 5 V +1 03/17/23, 20:57

  12. Jochen Roth uploaded patch set 6 03/17/23, 20:59

  13. Benni Mack voted on patch set 6 CR +1 03/17/23, 21:01

  14. Jochen Roth commented on patch set 6 03/17/23, 21:01

    DataHandler.php:2406

    @oli, hope this change is ok.
  15. core-ci voted on patch set 5 V +1 03/17/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39159

  16. core-ci voted on patch set 6 V +1 03/17/23, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39160

  17. Guido Schmechel commented on patch set 6 03/17/23, 21:12

    space
    EXT:
  18. Jochen Roth uploaded patch set 7 CR +1 V +1 03/18/23, 08:32

  19. Jochen Roth commented on patch set 7 03/18/23, 08:33

    Reply

    Done

    Reply

    Done
  1. core-ci voted on patch set 7 V +1 03/18/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39177

  2. Stefan Bürk voted on patch set 7 V +1 CR +1 03/18/23, 09:14

  3. Georg Ringer voted on patch set 7 V +1 CR +1 03/19/23, 16:39

  4. Jochen Roth updated the commit message in patch set 8 CR +1 V +1 03/20/23, 11:11

  5. core-ci voted on patch set 8 V +1 03/20/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39232

  6. Stefan Bürk voted on patch set 8 V +1 CR +1 03/20/23, 11:22

  7. Christian Kuhn commented on patch set 8 03/20/23, 12:39

    could we eventually have a DH scenario test for this? i guess it shouldn't be *that* complicated to feed DB with a uuid record, and the copy that record around via DH action?
  8. Oli Bartsch commented on patch set 8 03/20/23, 20:20

    DataHandler.php:2406 Reply

    Ack

    DataHandler.php:2415

    Both @param and @return should be skipped as they add no additional value.
  9. Jochen Roth uploaded patch set 9 CR +1 V +1 03/21/23, 08:45

  10. Jochen Roth commented on patch set 9 CR -1 03/21/23, 08:46

    Still on it.

    DataHandler.php:2415 Reply

    Done
  11. core-ci voted on patch set 9 V -1 03/21/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39300

  12. Jochen Roth uploaded patch set 10 CR -1 V -1 03/22/23, 09:20

  13. Jochen Roth commented on patch set 10 V -1 CR -1 03/22/23, 09:23

    Needs for workspace testing (copy, move, publish). How to handle the UUID if in the workspace?! Are simply generating a new UUID (workspace specific) and reset it to the live uuid of a record when publishing?
  14. core-ci voted on patch set 10 V -1 03/22/23, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39367

  15. Benni Mack commented on patch set 10 04/13/23, 13:06

    what should be the expectation when copying a record or when modifying a record in a workspace?
  16. Jochen Roth commented on patch set 10 04/13/23, 13:44

    Reply

    IMO, a new uuid is generated for the workspace. On publish it should never update the uuid of the live record.
  17. Benni Mack updated the commit message in patch set 11 CR -1 V -1 05/03/23, 09:44

  18. Jochen Roth abandoned the change 07/06/23, 12:05

    Not a issues anymore. It just worked.
  19. Jochen Roth restored the change 07/06/23, 12:14

  20. Andreas Wolf commented on patch set 11 07/06/23, 15:56

    Reply

    I tend to disagree here – what is the purpose of the UUID if it changes in the workspace? From what I've seen in projects, UUIDs are viewed as a kind of persistent, unique, technical identifier for a "thing". Creating a copy creates a new, different "thing", therefore a new UUID is justified then; however, changing properties in a workspace does not change that "things" identity, and thus the UUID should stay the same.
  21. Jochen Roth uploaded patch set 12 07/07/23, 12:58

  22. Susi Moog commented on patch set 12 07/07/23, 13:02

    Reply Unresolved

    @Andreas We had a talk here at the sprint and there's basically two different things. One is the UUID per element (what we are using here to identify each record separately) and the other would be the aggregate root uuid where an element would have the same uuid across all dimensions (Language, Workspaces for example). If we want to implement the latter concept (which could also help in various other places on resolving and managing system-integrity) that would be a different feature. In this context here the uuid shold be unique.
  23. core-ci voted on patch set 12 V +1 07/07/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43907

  24. Christian Kuhn commented on patch set 12 11/23/23, 21:21

  25. Christian Kuhn abandoned the change 11/23/23, 21:21