Review main Abandoned

78164[FEATURE] Add allowedNew and deniedNew to mod.web_list.table

JAKOTA Design Group GmbH CR 0 V -1 Normal +87 −8 updated 03/15/26, 14:50

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • Georg Ringer -1
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. JAKOTA Design Group GmbH uploaded patch set 1 03/17/23, 22:02

  2. core-ci voted on patch set 1 V +1 03/17/23, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39164

  3. JAKOTA Design Group GmbH uploaded patch set 2 V +1 03/18/23, 08:46

  4. core-ci voted on patch set 2 V +1 03/18/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39180

  5. Georg Ringer commented on patch set 2 V -1 03/19/23, 15:49

    even though this sounds nice at the 1st place I don't like to add another API for that. Reasons are: - integrators or extension authors should use "mod.web_list.deniedNewTables := addToList(sys_template)" to modify the list - it makes it harder to debug why something doesn't work because there are now 2 options which need to be checked - another method to the big ugly BackendUtility
  6. JAKOTA Design Group GmbH commented on patch set 2 03/19/23, 21:41

    Reply

    Thanks for your input. 1. In that case I would like the docs to be changed: https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/Mod.html#deniednewtables gives the wrong example. 2. The old way could be deprecated? 3. Was I supposed to add the same code to 3 different files?
  7. Georg Ringer abandoned the change 03/15/26, 14:50

    as stated in the issue, the change has been rejected in favor of an improved docs