Review main Merged

78165[FEATURE] Add ATagParams option to links of restricted pages

Benni Mack CR +2 V +2 Normal +144 −53 updated 03/20/23, 11:28

Commit message

A new TypoScript option is introduced to allow to set
additional tag attributes to links of pages which are
access restricted but link to a login page.

This works globally for a page, but also for HMENUs.

Globally:
  config.typolinkLinkAccessRestrictedPages.ATagParams = class="restricted"

for HMENUs:

  page.10 = HMENU
  page.10.showAccessRestrictedPages = 13
  page.10.showAccessRestrictedPages.ATagParams = class="access-restricted"

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Benni Mack uploaded patch set 1 03/17/23, 22:14

  2. core-ci voted on patch set 1 V -1 03/17/23, 23:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39166

  3. Benni Mack uploaded patch set 2 V -1 03/19/23, 22:27

  4. core-ci voted on patch set 2 V +1 03/19/23, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39210

  5. Oli Bartsch uploaded patch set 3 V +1 03/20/23, 09:18

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 03/20/23, 09:19

  7. core-ci voted on patch set 3 V +1 03/20/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39226

  8. Jochen Roth voted on patch set 3 V +1 CR +1 03/20/23, 11:05

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 03/20/23, 11:28

  10. Oli Bartsch merged patch set 4 03/20/23, 11:28