78174[TASK] Improve performance of FormEngine mass editing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCategory.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFiles.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+5 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+4 −0
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php+8 −0
Review log 1017
-
Christian Eßl uploaded patch set 1 03/20/23, 14:11
-
core-ci voted on patch set 1 V -1 03/20/23, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39243
-
Christian Eßl uploaded patch set 2
V -103/20/23, 14:53 -
core-ci voted on patch set 2 V -1 03/20/23, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39247
-
Christian Eßl uploaded patch set 3
V -103/20/23, 15:54 -
core-ci voted on patch set 3 V -1 03/20/23, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39256
-
Christian Eßl uploaded patch set 4
V -103/20/23, 16:56 -
core-ci voted on patch set 4 V +1 03/20/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39261
-
Christian Kuhn commented on patch set 4 03/20/23, 17:53
Hmm. Complex. Note there is also 'columnsToProcess' which is calculated at some places when a field has a dependency to another field. Did you check if this may eventually collide? Not preparing a field anymore if it is a dependency of another field may lead to trouble. -
Oli Bartsch commented on patch set 4 03/20/23, 17:58
Reply Unresolved
Additionally, if at all, I would prefer to call the new key "columnsToRender". -
Simon Schaufelberger uploaded patch set 5
V +108/14/23, 05:35 -
core-ci voted on patch set 5 V +1 08/14/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45465
-
Simon Schaufelberger uploaded patch set 6
V +108/14/23, 05:42 -
Simon Schaufelberger uploaded patch set 7 08/14/23, 05:44
-
core-ci voted on patch set 7 V +1 08/14/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45467
-
core-ci voted on patch set 6 V +1 08/14/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45466
-
Benni Mack abandoned the change 12/04/24, 11:09
I will abandon this change for the time being, can be restored later once somebody is picking this one up.