Review main Abandoned

78174[TASK] Improve performance of FormEngine mass editing

Christian Eßl CR 0 V 0 Easy +38 −10 updated 12/04/24, 11:09

Commit message

When using the mass editing feature of FormEngine, available in
the list module, usually only a limited selection of fields is
required for doing so. However, internally the FormEngine always
compiled all the available fields of a record, even those not
needed for current editing.

In case of TCA types that use database relations (like the
types 'inline', 'file', 'group' or 'category'), this quickly
resulted in a huge count of superfluous db queries, making the
mass editing feature really slow.

The number of db queries, when editing only selected fields,
is now greatly reduced by adding a check, if the field should
be rendered in the FormEngine.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 1017

  1. Christian Eßl uploaded patch set 1 03/20/23, 14:11

  2. core-ci voted on patch set 1 V -1 03/20/23, 14:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39243

  3. Christian Eßl uploaded patch set 2 V -1 03/20/23, 14:53

  4. core-ci voted on patch set 2 V -1 03/20/23, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39247

  5. Christian Eßl uploaded patch set 3 V -1 03/20/23, 15:54

  6. core-ci voted on patch set 3 V -1 03/20/23, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39256

  7. Christian Eßl uploaded patch set 4 V -1 03/20/23, 16:56

  8. core-ci voted on patch set 4 V +1 03/20/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39261

  9. Christian Kuhn commented on patch set 4 03/20/23, 17:53

    Hmm. Complex. Note there is also 'columnsToProcess' which is calculated at some places when a field has a dependency to another field. Did you check if this may eventually collide? Not preparing a field anymore if it is a dependency of another field may lead to trouble.
  10. Oli Bartsch commented on patch set 4 03/20/23, 17:58

    Reply Unresolved

    Additionally, if at all, I would prefer to call the new key "columnsToRender".
  11. Simon Schaufelberger uploaded patch set 5 V +1 08/14/23, 05:35

  12. core-ci voted on patch set 5 V +1 08/14/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45465

  13. Simon Schaufelberger uploaded patch set 6 V +1 08/14/23, 05:42

  14. Simon Schaufelberger uploaded patch set 7 08/14/23, 05:44

  15. core-ci voted on patch set 7 V +1 08/14/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45467

  16. core-ci voted on patch set 6 V +1 08/14/23, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45466

  17. Benni Mack abandoned the change 12/04/24, 11:09

    I will abandon this change for the time being, can be restored later once somebody is picking this one up.