78176[BUGFIX] Ensure table contents are vertically centered
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 3
Review log 2127
Show 12 earlier messages
-
Benjamin Kott uploaded patch set 1 03/20/23, 14:36
-
core-ci voted on patch set 1 V +1 03/20/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39245
-
Benjamin Kott uploaded patch set 2
V +104/06/23, 13:14 -
Andreas Kienast updated the commit message in patch set 3 04/06/23, 13:22
-
core-ci voted on patch set 2 V +1 04/06/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40291
-
core-ci voted on patch set 3 V +1 04/06/23, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40292
-
Christian Kuhn commented on patch set 3 V -1 04/06/23, 17:09
I don't agree. To me, it looks much better when table data is top-aligned when the row is bigger. That's actually the reason we changed that (relatively recently). I uploaded 2 screens to the forge issue to give an idea on this. I admit this is a bit matter of taste and will remove my -1 if the majority is in favor of vertically-center, but I think we should at least hear more persons to get a better feeling on this? What do you think? -
Jasmina Ließmann commented on patch set 3 V -1 04/06/23, 17:18
Unresolved
I'm against vertically centering the table content. IMHO this makes the appearance more choppy/fluttering and in most cases more difficult to read as each table row can have a different height (depending on the content in the table columns). In addition, the text always begins at a different position, depending on how much text is contained in the table columns). Positioning vertically at the top means that the content always starts at the same place - line for line, regardless of its content. Which makes it easier to read and makes the content easier to grasp. -
Benjamin Kott commented on patch set 3 04/06/23, 21:10
see issue for problematic weavy lines -
Markus Klein commented on patch set 3 04/07/23, 08:44
Opinion: Looking at the representation of a table in a graphical way, the centering seems smoother to my eyes. Thinking about longer tables, where I'm searching with my eyes for something in the first column is way easier, if the text always starts straight below the line. So a top-alignment would be preferred. And one thing I throw into the thinking-process here: M$ Excel has a default cell alignment for new files to bottom! (I never questioned that, I hope they thought about it.) -
Annett Jähnichen commented on patch set 3 04/07/23, 12:26
Unresolved
Currently the scheduler module looks more broken to me, so I would give the patch a chance if we could find a better solution for the siteconfig later. -
Christoph Lehmann commented on patch set 3 04/08/23, 16:20
I have a multi-site system with 100+ languages for each site. In v11 the site identifier is vertical centered and it feels not good. I prefer the top alignment over the centered alignment. -
Benni Mack updated the commit message in patch set 4
V +105/03/23, 09:53 -
Christoph Lehmann wrote 07/02/23, 19:29
Removed cc Christoph Lehmann. -
Tobi Kretschmann commented on patch set 4 08/03/23, 19:32
How should we proceed with this one? My opinion: Single lines should definitely be centered to avoid wavy lines. I can also see the point for long (horizontally scrolling) lists loosing focus. Since this topic mostly relies on personal preference, is there a way to compromise? -
Simon Schaufelberger uploaded patch set 5 04/22/24, 17:47
-
Simon Schaufelberger commented on patch set 5 04/22/24, 17:47
Reply
ping @benjamin.kott@outlook.com -
core-ci voted on patch set 5 V +1 04/22/24, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56505
-
Riccardo De Contardi commented on patch set 5 06/12/24, 12:54
Reply
I have the same opinion; For tables with uniform content, such as numeric data or single words in each cell, centered alignment creates a visually balanced and clean look; on the other hand for tables with uneven content, like multiline text or data-heavy cells, top alignment improves readability and consistency by keeping the starting point uniform -
Benni Mack updated the commit message in patch set 6
V +110/18/24, 13:32 -
core-ci voted on patch set 6 V -1 10/18/24, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67988
-
Ayke Halder commented on patch set 6 02/04/25, 13:48
Reply Unresolved
https://www.pencilandpaper.io/articles/ux-pattern-analysis-enterprise-data-tables#vertical-alignment > Use vertical center-align for when the row height varies only slightly (up to 3 lines). Centering the text vertically within row height spreads out the white space within the table and thus eases visual scan. > If row height varies more than 3 or 4 lines, using top-alignment makes most sense in terms of legibility and ensuring everything is visible. > Multi-line cells should stick to the top of the cell to ensure everything is visible at first glance. Sticking to the bottom of the cells sometimes causes content to be hidden away (cells risk being clipped by browser viewport edges) and requires scrolling, but then if scrolling jumps to the next row, the experience is very jerky and disorienting and you risk never seeing the full cell content. -
Benni Mack marked it work in progress 03/27/25, 20:55
-
Oli Bartsch uploaded patch set 7
V -109/26/25, 10:59 -
Oli Bartsch commented on patch set 7 09/26/25, 11:01
This change is ready for review.Unresolved
I’d like to warm up this discussion again and have rebased the patch. -
core-ci voted on patch set 7 V +1 09/26/25, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85590
-
Benjamin Kott abandoned the change 10/10/25, 09:17
abandon for now