Review main Merged

78177[TASK] Improve the save notification in mass editing mode

Christian Eßl CR +2 V +2 Easy +6 −0 updated 07/04/23, 21:03

Commit message

The new save notification currently lists all changes separately,
when editing records in EditDocumentController.
This leads to a huge notification box, when saving many records
at once.

The behaviour is now changed so that if more than 10 records
were edited, a more generic message is shown instead:

"x records have been successfully saved."

Review

  • Code review CR +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Annett Jähnichen +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Christian Eßl uploaded patch set 1 03/20/23, 14:50

  2. core-ci voted on patch set 1 V +1 03/20/23, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39246

  3. Annett Jähnichen uploaded patch set 2 V +1 07/04/23, 17:23

  4. core-ci voted on patch set 2 V +1 07/04/23, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43410

  5. Frank Nägler voted on patch set 2 V +1 CR +1 07/04/23, 20:36

  6. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 07/04/23, 20:43

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 07/04/23, 20:43

  8. core-ci voted on patch set 3 V +1 07/04/23, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43440

  9. Frank Nägler voted on patch set 3 V +1 CR +1 07/04/23, 20:57

  10. Annett Jähnichen voted on patch set 3 V +2 CR +2 07/04/23, 21:03

  11. Annett Jähnichen merged patch set 4 07/04/23, 21:03