78180[TASK] Raise php-cs-fixer dev dependency to 3.15
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Benni Mack uploaded patch set 1 03/20/23, 15:35
-
core-ci voted on patch set 1 V +1 03/20/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39253
-
Oliver Klee voted on patch set 1 V +1 CR +1 03/20/23, 15:44
-
Benni Mack updated the commit message in patch set 2
CR +1V +103/20/23, 16:30 -
core-ci voted on patch set 2 V +1 03/20/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39260
-
Christian Kuhn commented on patch set 2 V +2 CR +2 03/20/23, 17:24
checked nightly: Build/Scripts/runTests.sh -s cgl -n -p 8.1 seems to stay green. -
Christian Kuhn merged patch set 3 03/20/23, 17:24
-
Christian Kuhn commented on patch set 3 03/20/23, 17:32
v11: composer req --dev friendsofphp/php-cs-fixer:^3.15 Problem 1 - Root composer.json requires friendsofphp/php-cs-fixer ^3.15 -> satisfiable by friendsofphp/php-cs-fixer[v3.15.0, v3.15.1]. - friendsofphp/php-cs-fixer[v3.15.0, ..., v3.15.1] require doctrine/annotations ^2 -> found doctrine/annotations[2.0.0, 2.0.1] but it conflicts with your root composer.json require (^1.11). And similar with lexer ... Maybe just keep ^3.14 in v11, so no v11 backport of this patch? -
Oliver Klee commented on patch set 3 03/20/23, 17:47
Reply
Yeah, sounds reasonable. -
Christian Kuhn commented on patch set 3 03/21/23, 10:21
backport skipped.