Review main Merged

78197[TASK] Separate concerns in EXT:scheduler

Benni Mack CR +2 V +2 Expert +904 −393 updated 03/22/23, 16:00

Commit message

This change finally cleans up logic within
the scheduler extension, namely to separate
concerns regarding reading from and writing to
the database.

All of these methods are moved to a Repository
class in order to handle database access into
one class, and to untangle the tight coupling
between the Scheduler class and the Task class.

In addition, the AbstractTask will become
a lot smaller, as it only deals with the actual
execution of the code in the future.

A new TaskValidator is added to validate if a
task can be executed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 17