Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

78198[WIP][TASK] Introduce resource move in filelist

Benjamin Kott CR 0 V 0 Hard +600 −101 updated 01/24/25, 11:22

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/78198/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/78198/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1524

  1. Benjamin Kott uploaded patch set 1 03/21/23, 15:59

  2. core-ci voted on patch set 1 V +1 03/21/23, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39326

  3. Benjamin Kott uploaded patch set 2 V +1 03/22/23, 15:28

  4. core-ci voted on patch set 2 V +1 03/22/23, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39395

  5. Benni Mack updated the commit message in patch set 3 V +1 03/22/23, 19:41

  6. core-ci voted on patch set 3 V +1 03/22/23, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39413

  7. Benjamin Kott uploaded patch set 4 V +1 03/23/23, 09:34

  8. core-ci voted on patch set 4 V +1 03/23/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39448

  9. Benjamin Kott uploaded patch set 5 V +1 03/23/23, 10:12

  10. core-ci voted on patch set 5 V +1 03/23/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39453

  11. Wiktor Woźny commented on patch set 5 V +1 03/27/23, 09:36

    `My conclusions from testing this module: Drag 'n drop: Dragging single compressed files (.xz, .rar, .7zip) - Works correctly Dragging three files at once (.csv) - Works correctly Dragging a single html file - Works correctly Dragging three .html files at once - Works correctly after several attempts (Upload of file "file_name.html-178:-76:64:64" failed!). There were some issues where only a white bar (class="table-fit") appeared under the h1 element during upload, and the file was not transmitted, requiring multiple attempts. Nesting folders - Works correctly Dragging single files in formats .gif, .bmp, .jpeg, .jgp, .png, .svg - Works correctly Encountered some difficulties with the .webp format (Upload of file "img-webp.webp-49:-26:63:63" failed!) where a white bar (class="table-fit") sometimes appeared during upload, and multiple attempts were necessary. Moving several folders by selecting them with a checkbox - Works correctly Moving several images to another folder by selecting them with a checkbox - Works correctly Buttons located in div with class 'module-docheader-bar-column-left' - Work correctly Some files exist already - modal - Works correctly
  12. Wiktor Woźny commented on patch set 5 03/27/23, 11:06

    Reply

    The browsers I tested on: -Google Chrome Version 111.0.5563.64 (Official Build) (64-bit) -Firefox 111.0.1 (64-bit) On Firefox, everything worked much better, and I never encountered the error message 'Upload of file "img-name.webp-49:-26:63:63" failed!'"
  13. Tymoteusz Motylewski voted on patch set 5 V +1 03/29/23, 09:01

  14. Tymoteusz Motylewski uploaded patch set 6 V +1 04/05/23, 07:18

  15. Tymoteusz Motylewski updated the commit message in patch set 7 04/05/23, 07:20

  16. Tymoteusz Motylewski commented on patch set 7 04/05/23, 07:20

    rebased and changed to task, as discussed with Benni Mack
  17. core-ci voted on patch set 7 V +1 04/05/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40153

  18. core-ci voted on patch set 6 V +1 04/05/23, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40152

  19. Benjamin Kott commented on patch set 7 04/07/23, 17:36

    Quick headsup here. i am not sure what has been in testing here - but seems to be a different scope. This patch is about moving resources through a wizard. Select files, press move. - See pagetree broken - See selected resources displayed on the right side. - See no action implemented on move
  20. Benjamin Kott uploaded patch set 8 V +1 04/07/23, 18:13

  21. core-ci voted on patch set 8 V +1 04/07/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40352

  22. Benjamin Kott rebased onto patch set 9 V +1 04/11/23, 07:10

  23. core-ci voted on patch set 9 V +1 04/11/23, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40441

  24. Benni Mack marked it work in progress 01/24/25, 11:22