78208[TASK] Update lit JavaScript dependencies
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 128
- Build/JSUnit/Globals.js+12 −12
- Build/JSUnit/Helper.js+20 −20
- Build/JSUnit/karma.conf.ci.js+2 −0
- Build/JSUnit/karma.conf.js+14 −12
- Build/Gruntfile.js+16 −18
- Build/package-lock.json+65 −25
- Build/package.json+5 −4
- typo3/sysext/core/Configuration/JavaScriptModules.php+8 −8
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/base.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/custom-element.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/event-options.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/property.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-all.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-assigned-elements.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-assigned-nodes.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query-async.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/query.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators/state.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/decorators.jsrenamed+1 −1
Show 108 more files
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/polyfill-support.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-controller.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element@1.0.0/decorators/custom-element.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element@1.0.0/decorators/query-assigned-nodes.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element@1.0.0/css-tag.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element@1.0.0/reactive-element.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/custom-element.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/event-options.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/property.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/query-all.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/query-assigned-elements.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/query-assigned-nodes.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/query-async.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/query.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators/state.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/async-append.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/async-replace.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/cache.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/choose.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/class-map.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/guard.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/if-defined.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/join.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/keyed.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/live.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/map.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/range.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/ref.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/repeat.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/style-map.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/template-content.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/unsafe-html.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/unsafe-svg.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/until.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directives/when.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/async-directive.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/decorators.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directive-helpers.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/directive.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/experimental-hydrate-support.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/experimental-hydrate.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/html.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/index.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/polyfill-support.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit/static-html.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/custom-element.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/event-options.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/property.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/query-all.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/query-assigned-elements.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/query-assigned-nodes.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/query-async.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/query.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators/state.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/decorators.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/experimental-hydrate-support.jsnew+7 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/index.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/polyfill-support.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/private-ssr-support.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element@3.0.0/experimental-hydrate-support.jsdeleted+0 −7
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element@3.0.0/lit-element.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element@3.0.0/polyfill-support.jsdeleted+0 −13
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/async-append.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/async-replace.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/cache.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/choose.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/class-map.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/guard.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/if-defined.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/join.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/keyed.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/live.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/map.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/private-async-helpers.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/range.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/ref.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/repeat.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/style-map.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/template-content.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/unsafe-html.jsrenamed+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/unsafe-svg.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/until.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directives/when.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/async-directive.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directive-helpers.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/directive.jsrenamed+0 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/experimental-hydrate.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/is-server.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/polyfill-support.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/private-ssr-support.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/static.jsnew+6 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directives/async-replace.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directives/class-map.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directives/private-async-helpers.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directives/ref.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directives/until.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/async-directive.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/directive-helpers.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/experimental-hydrate.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/lit-html.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/polyfill-support.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/private-ssr-support.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html@2.0.0/static.jsdeleted+0 −6
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit@2.0.0/index.jsdeleted+0 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit@2.0.0/polyfill-support.jsdeleted+0 −13
Review log 1316
-
Benjamin Kott uploaded patch set 1 03/22/23, 09:06
-
Benni Mack voted on patch set 1 V +1 CR +1 03/22/23, 09:15
-
Frank Nägler voted on patch set 1 V +1 CR +1 03/22/23, 09:18
-
core-ci voted on patch set 1 V -1 03/22/23, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39366
-
Benjamin Kott uploaded patch set 2
CR +1V +103/22/23, 09:38 -
Frank Nägler voted on patch set 2 V +1 CR +1 03/22/23, 09:41
-
core-ci voted on patch set 2 V -1 03/22/23, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39368
-
Benjamin Kott uploaded patch set 3
CR +1V +103/22/23, 11:13 -
core-ci voted on patch set 3 V +1 03/22/23, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39374
-
Benni Mack voted on patch set 3 V +1 CR +1 03/22/23, 11:27
-
Frank Nägler voted on patch set 3 V +1 CR +1 03/22/23, 11:27
-
Benni Mack voted on patch set 3 V +2 CR +2 03/22/23, 11:50
-
Benni Mack merged patch set 4 03/22/23, 11:51
-
Benjamin Franzke commented on patch set 4 03/22/23, 23:15
The version numbers have been added on purpose, in order to act as cache-bust (similar to common cdn-providers), as the files include each other via relatice paths, and as such, the browsers will now no longer notice an update to a lit-internal-helper-file. So, the *next* (after this one) lit-update would mix versions for browsers that already have the js-sources in cache. Note that the importmap cachebusting from https://review.typo3.org/c/Packages/TYPO3.CMS/+/72637 does only work for bare-imports, not for realtive ones. I'd love to have versioned-extension-asset-paths, but I didn't manage do add that for security reasons, as that'd be an information disclosure, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/75924 Did you face an issue with the version numbers, or were they mainly removed for cosmetical reasons? Otherwise I'd propose a patch that reintroduces the version numbers for lit. -
Benjamin Franzke commented on patch set 4 03/22/23, 23:17
Unresolved
yup, right. It wasn't meant to ship multiple version, therefore the mapping was done by the importmap. (and yes, that's a manual update :\ ) -
Benjamin Franzke commented on patch set 4 11/03/25, 16:47
Reply Unresolved
Btw, the mentioned cachebusting bug that was introduced with this change has later been solved by rewriting the lit sources to use bare module specifiers everywhere: > 80268: [TASK] Map relative lit-imports to bare module specifiers | https://review.typo3.org/c/Packages/TYPO3.CMS/+/80268 I'm still not happy that this change implicitly removed compile time cache busting, resulting in uneeded rewrites and runtime cache busting. For context, this just came up again in https://typo3.slack.com/archives/C03AM9R17/p1762187746093829 as the core part that provided support for this syntax is still implemented, but has no core-usage left.