78211[TASK] Change sorting of records in recycler module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Stefan Froemken +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1518
-
Georg Ringer uploaded patch set 1 03/22/23, 13:37
-
Georg Ringer commented on patch set 1 03/22/23, 13:37
This change is ready for review. -
Philipp Gampe voted on patch set 1 CR +1 03/22/23, 13:48
-
core-ci voted on patch set 1 V -1 03/22/23, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39384
-
Stefan Bürk commented on patch set 1 03/22/23, 15:02
DeletedRecords.php:242to be absolutly safe, and additionally `->addOrderBy('uid','desc')' should be added here. (2nd level sort criteria if 1st level has same value) Eventually, it's only test fixture data related - would ensure that there too. Still opting for the 2nd level criteria here. -
Nikita Hovratov uploaded patch set 2
CR +1V -103/22/23, 16:35 -
Nikita Hovratov commented on patch set 2 03/22/23, 16:35
DeletedRecords.php:242ReplyDone -
core-ci voted on patch set 2 V +1 03/22/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39402
-
Stefan Bürk commented on patch set 2 CR -1 03/22/23, 20:27
on it ... -
Christian Eßl wrote 04/02/23, 08:48
Removed reviewer Christian Eßl. -
Benni Mack updated the commit message in patch set 3
CR -1V +105/03/23, 09:42 -
Georg Ringer rebased onto patch set 4 05/10/23, 13:19
-
core-ci voted on patch set 4 V +1 05/10/23, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41725
-
Stefan Froemken voted on patch set 4 V +1 CR +1 05/10/23, 15:29
-
Benni Mack voted on patch set 4 CR +1 07/04/23, 09:49
-
Stefan Bürk voted on patch set 4 V +1 CR +1 07/04/23, 09:52
-
Benni Mack voted on patch set 4 V +2 CR +2 07/04/23, 09:54
-
Benni Mack merged patch set 5 07/04/23, 09:54