Review main Merged

78211[TASK] Change sorting of records in recycler module

Georg Ringer CR +2 V +2 Easy +11 −7 updated 07/04/23, 09:54

Commit message

The deleted records should be sorted by the timestamp descending instead
of by the uid ascending because in most cases one of the recently
deleted records should be restored.

In addition, a comparison is fixed as a drive-by change to have
compatible types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1518

  1. Georg Ringer uploaded patch set 1 03/22/23, 13:37

  2. Georg Ringer commented on patch set 1 03/22/23, 13:37

    This change is ready for review.
  3. Philipp Gampe voted on patch set 1 CR +1 03/22/23, 13:48

  4. core-ci voted on patch set 1 V -1 03/22/23, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39384

  5. Stefan Bürk commented on patch set 1 03/22/23, 15:02

    DeletedRecords.php:242

    to be absolutly safe, and additionally `->addOrderBy('uid','desc')' should be added here. (2nd level sort criteria if 1st level has same value) Eventually, it's only test fixture data related - would ensure that there too. Still opting for the 2nd level criteria here.
  6. Nikita Hovratov uploaded patch set 2 CR +1 V -1 03/22/23, 16:35

  7. Nikita Hovratov commented on patch set 2 03/22/23, 16:35

    DeletedRecords.php:242 Reply

    Done
  8. core-ci voted on patch set 2 V +1 03/22/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39402

  9. Stefan Bürk commented on patch set 2 CR -1 03/22/23, 20:27

    on it ...
  10. Christian Eßl wrote 04/02/23, 08:48

    Removed reviewer Christian Eßl.
  11. Benni Mack updated the commit message in patch set 3 CR -1 V +1 05/03/23, 09:42

  12. Georg Ringer rebased onto patch set 4 05/10/23, 13:19

  13. core-ci voted on patch set 4 V +1 05/10/23, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41725

  14. Stefan Froemken voted on patch set 4 V +1 CR +1 05/10/23, 15:29

  15. Benni Mack voted on patch set 4 CR +1 07/04/23, 09:49

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 07/04/23, 09:52

  17. Benni Mack voted on patch set 4 V +2 CR +2 07/04/23, 09:54

  18. Benni Mack merged patch set 5 07/04/23, 09:54