Review main Merged

78224[BUGFIX] Resolve some `Function`-related eslint warnings

Andreas Kienast CR +2 V +2 Normal +55 −62 updated 03/23/23, 10:11

Commit message

eslint became stricter lately and warns about possible bugs in
TypeScript code. This patch tackles some warnings regarding `Function`:
```
Don't use `Function` as a type. The `Function` type accepts any
function-like value.
```

In `element-browser.ts` was an obsolete declaration of
`window.setFormValueFromBrowseWin`, which was removed in TYPO3 v11
already.

Also, an internal polyfill for `closest()` was removed in FormEngine.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 56

  1. Andreas Kienast uploaded patch set 1 03/23/23, 08:40

  2. core-ci voted on patch set 1 V +1 03/23/23, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39442

  3. Benjamin Kott voted on patch set 1 V +1 CR +1 03/23/23, 09:28

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 03/23/23, 09:29

  5. Andreas Kienast merged patch set 2 03/23/23, 09:29

  6. Oliver Hader voted on patch set 2 CR +1 03/23/23, 10:11