Review main Merged

78229[TASK] Get rid of ColumnMap::$relationTablePageIdColumnName

Alexander Schnitzler CR +2 V +2 Normal +2 −82 updated 03/23/23, 11:07

Commit message

That property always held string "pid" if TCA for the
defined foreign_table exists. This field is only
evaluated at one place in the Backend class, when
persisting new rows into foreign_table. Therefore,
ColumnMap does not need to carry around said value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 03/23/23, 10:38

  2. Alexander Schnitzler wrote 03/23/23, 10:39

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 03/23/23, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39457

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 03/23/23, 10:56

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 03/23/23, 11:07

  6. Stefan Bürk merged patch set 2 03/23/23, 11:07