78232[TASK] Add pagination to LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 22
- Build/Sources/Sass/component/_livesearch.scss+17 −0
- Build/Sources/Sass/module/_recycler.scss+0 −4
- Build/Sources/Sass/typo3/_element_pagination.scss+7 −0
- Build/Sources/TypeScript/backend/live-search/element/result/item/item-container.ts+7 −1
- Build/Sources/TypeScript/backend/live-search/element/result/result-pagination.tsnew+121 −0
- Build/Sources/TypeScript/backend/live-search/element/show-all.tsdeleted+0 −56
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+43 −18
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+20 −4
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/MutableSearchDemand.php+5 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchDemand/SearchDemand.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+138 −41
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+77 −44
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchProviderInterface.php+2 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/SearchRepository.php+49 −16
- typo3/sysext/backend/Resources/Private/Templates/LiveSearch/Form.html+3 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/item/item-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/result-pagination.jsnew+45 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/show-all.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
Review log 1321
-
Andreas Kienast uploaded patch set 1 03/23/23, 13:08
-
core-ci voted on patch set 1 V -1 03/23/23, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39470
-
Andreas Kienast uploaded patch set 2
V -103/24/23, 07:58 -
core-ci voted on patch set 2 V +1 03/24/23, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39521
-
Andreas Kienast uploaded patch set 3
V +103/24/23, 13:56 -
core-ci voted on patch set 3 V -1 03/24/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39555
-
Andreas Kienast uploaded patch set 4
V -103/24/23, 14:24 -
core-ci voted on patch set 4 V +1 03/24/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39558
-
Andreas Kienast uploaded patch set 5
V +103/24/23, 19:58 -
core-ci voted on patch set 5 V +1 03/24/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39594
-
Andreas Kienast uploaded patch set 6
V +103/24/23, 20:24 -
core-ci voted on patch set 6 V +1 03/24/23, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39597
-
Guido Schmechel commented on patch set 6 03/25/23, 09:31
Got some weird behaviour here. Initial situation: For one keyword I find 7 pages, 1 sys_template and 2x tt_content -> 10 hits If I now change the limit in Demand to 2, sys_template suddenly flies out and returns zero. The pagination itself works fine. I have backed up the database status if necessary. My guess, however, goes in the direction of MutableSearchDemand. -
Andreas Kienast uploaded patch set 7
V +103/27/23, 12:51 -
core-ci voted on patch set 7 V +1 03/27/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39695
-
Andreas Kienast uploaded patch set 8
V +103/27/23, 14:00 -
Andreas Kienast uploaded patch set 9 03/27/23, 14:01
-
core-ci voted on patch set 9 V +1 03/27/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39700
-
Guido Schmechel voted on patch set 9 V +1 CR +1 03/27/23, 14:42
-
Benni Mack voted on patch set 9 V +2 CR +2 03/27/23, 15:56
-
Benni Mack merged patch set 10 03/27/23, 15:56