Review main Merged

78232[TASK] Add pagination to LiveSearch

Andreas Kienast CR +2 V +2 Hard +539 −230 updated 03/27/23, 15:56

Commit message

The `SearchRepository` class used in the LiveSearch is now able to
handle pagination, allowing to render a pagination in the search modal
window. The `SearchProviderInterface` received a new method `count()`
used to calculcate the amount of potential results.

Since pagination is available now, the "Show all" button in the
LiveSearch serves no real purpose anymore and is therefore removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1321

  1. Andreas Kienast uploaded patch set 1 03/23/23, 13:08

  2. core-ci voted on patch set 1 V -1 03/23/23, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39470

  3. Andreas Kienast uploaded patch set 2 V -1 03/24/23, 07:58

  4. core-ci voted on patch set 2 V +1 03/24/23, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39521

  5. Andreas Kienast uploaded patch set 3 V +1 03/24/23, 13:56

  6. core-ci voted on patch set 3 V -1 03/24/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39555

  7. Andreas Kienast uploaded patch set 4 V -1 03/24/23, 14:24

  8. core-ci voted on patch set 4 V +1 03/24/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39558

  9. Andreas Kienast uploaded patch set 5 V +1 03/24/23, 19:58

  10. core-ci voted on patch set 5 V +1 03/24/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39594

  11. Andreas Kienast uploaded patch set 6 V +1 03/24/23, 20:24

  12. core-ci voted on patch set 6 V +1 03/24/23, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39597

  13. Guido Schmechel commented on patch set 6 03/25/23, 09:31

    Got some weird behaviour here. Initial situation: For one keyword I find 7 pages, 1 sys_template and 2x tt_content -> 10 hits If I now change the limit in Demand to 2, sys_template suddenly flies out and returns zero. The pagination itself works fine. I have backed up the database status if necessary. My guess, however, goes in the direction of MutableSearchDemand.
  14. Andreas Kienast uploaded patch set 7 V +1 03/27/23, 12:51

  15. core-ci voted on patch set 7 V +1 03/27/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39695

  16. Andreas Kienast uploaded patch set 8 V +1 03/27/23, 14:00

  17. Andreas Kienast uploaded patch set 9 03/27/23, 14:01

  18. core-ci voted on patch set 9 V +1 03/27/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39700

  19. Guido Schmechel voted on patch set 9 V +1 CR +1 03/27/23, 14:42

  20. Benni Mack voted on patch set 9 V +2 CR +2 03/27/23, 15:56

  21. Benni Mack merged patch set 10 03/27/23, 15:56