Review main Merged

78246[BUGFIX] Respect default value for confirmation in ext:install

Torben Hansen CR +2 V +2 Easy +4 −2 updated 03/27/23, 10:38

Commit message

The default value for a confirmation is currently not respected
in the install tool on UI level and a confirmation dialog will
always show the "deny" button as selected. On CLI level the
default value is however taken into account.

This change sets the default value of the confirm dialog buttons
depending on the `defaultValue` property of the confirmation. If
the `defaultValue` is `true`, the "confirm" button is selected,
otherwise the "deny" button is selected.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 03/24/23, 14:40

  2. core-ci voted on patch set 1 V +1 03/24/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39562

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/24/23, 15:06

  4. Oliver Hader voted on patch set 1 CR +1 03/26/23, 14:41

  5. Oliver Hader voted on patch set 1 V +2 CR +2 03/27/23, 10:37

  6. Oliver Hader merged patch set 2 03/27/23, 10:38