Review main Abandoned

78252[TASK] Add index to sys_news

Stefan Froemken CR 0 V 0 Easy +2 −1 updated 03/27/23, 20:08

Commit message

Prevent FTS while querying records
of TYPO3 table sys_news.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Stefan Froemken uploaded patch set 1 03/24/23, 21:13

  2. core-ci voted on patch set 1 V +1 03/24/23, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39604

  3. Benni Mack commented on patch set 1 03/24/23, 21:32

    I think we could declare this a task.
  4. Stefan Froemken updated the commit message in patch set 2 V +1 03/24/23, 22:04

  5. core-ci voted on patch set 2 V +1 03/24/23, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39612

  6. Stefan Bürk commented on patch set 2 03/24/23, 22:41

    ext_tables.sql:144

    I would rather disband the crdate from that combound index and add the `crdate` as additional/dedicated index.

    ext_tables.sql:144 Unresolved

    `startEndTime` please avoid camel casing in table names, also for index names. use lower case / snake case syntax instead
  7. Stefan Froemken commented on patch set 2 03/27/23, 16:56

    Reply

    Done

    ext_tables.sql:144 Reply Unresolved

    MySQL/MariaDB can only use ONE Index for a query. The columns from WHERE will be checked first in Index. Afterwards, the last column of the index can be used to sort the resultset. So, either we keep that index as is or I keep just crdate, as sorting produces a heavier load in that case.
  8. Stefan Froemken abandoned the change 03/27/23, 20:08

    The columns starttime, endtime, hidden and deleted are in 98% always 0. So the QueryParser decides: reading all data from disc is faster than reading and checking values from index. As no index is used now, it also make no sense to create an index on just crdate.