Review main Merged

78253[TASK] Use COUNT(*) in SchedulerTaskRepository

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 03/26/23, 08:27

Commit message

Counting by column name has to check against null
before. To speed up performance a little bit
we switch to COUNT(*).

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Thomas Hohn +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Froemken uploaded patch set 1 03/24/23, 21:29

  2. core-ci voted on patch set 1 V +1 03/24/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39606

  3. Oliver Klee voted on patch set 1 CR +1 03/24/23, 22:13

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/24/23, 22:36

  5. Thomas Hohn voted on patch set 1 V +1 CR +1 03/25/23, 09:33

  6. Nikita Hovratov voted on patch set 1 V +2 CR +2 03/26/23, 08:27

  7. Nikita Hovratov merged patch set 2 03/26/23, 08:27