Review main Abandoned

7826[BUGFIX] CONTENT can't select records from root page

Markus Klein CR 0 V 0 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The CONTENT TS-object is not able to select records from page uid 0.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 23

  1. Markus Klein commented on patch set 1 01/22/12, 20:20

    This just an untested suggestion to get this issue going.
  2. Markus Klein uploaded patch set 2 01/22/12, 20:20

  3. Tolleiv Nietsch commented on patch set 3 V 0 01/22/12, 20:20

    by team member; Looks good to me, approved
  4. Markus Klein uploaded patch set 3 01/22/12, 20:20

  5. Markus Klein commented on patch set 3 01/22/12, 20:20

    Had to fix the commit msg.
  6. Markus Klein commented on patch set 3 01/22/12, 20:20

    Fails; I would prefer that you didn't submit this Just had another look at the code. Actually this patch should NOT fix this issue, since checkPidArray() should block access to pid 0. I'm not sure why it obviously works with static_countries, but I've to investigate further. Stay tuned.
  7. Xavier Perseguers commented on patch set 3 01/22/12, 20:20

    Looks good to me, but someone else must approve Just want to say the change regardless of the actual problem looks good as this "bug" as been introduced at numerous places in Core when adding stdWrap to all properties.
  8. Johannes Feustel commented on patch set 1 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve
  9. Johannes Feustel commented on patch set 2 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve Works for me with 4.6.3
  10. Johannes Feustel commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve
  11. Myroslav Holyak commented on patch set 1 01/22/12, 20:20

    Looks good to me, but someone else must approve Bu why so weak comparison? Whay not === ?
  12. Myroslav Holyak commented on patch set 2 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve
  13. Myroslav Holyak commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve
  14. Jacco van der Post commented on patch set 1 01/22/12, 20:20

    Fails Sorry, doesn't work for me on 4.6.3, linenumber 7383 changed accordingly. Still can't make a typoscript select with pidInList = 0 grtz Jacco
  15. Jacco van der Post commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve I tested it again, this time with static_countries as a table and this worked! However a table from my own backendmodule still can only be read from outside pid 0. Is their some restriction which tables can be read with typoscript from pid 0?
  16. Andreas Bouche commented on patch set 1 01/22/12, 20:20

    Looks good to me, but someone else must approve Looks good, but I would also encourage to use an identity comparison (===).
  17. Andreas Bouche commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve
  18. Soeren Kracker commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve should be sufficient. Afaik it shouldn't have any side effects.
  19. Mr. Jenkins commented on patch set 1 01/22/12, 20:20

  20. Mr. Jenkins commented on patch set 2 01/22/12, 20:20

  21. Mr. Jenkins commented on patch set 3 01/22/12, 20:20

  22. Alain commented on patch set 3 01/22/12, 20:20

    Verified; Looks good to me, but someone else must approve Just some side notes: this patch is also available at https://review.typo3.org/#change,7839 Markus Klein wrote: Actually this patch should NOT fix this issue, since checkPidArray() should block access to pid 0. the if-construct with checkPidArray() in tslib_content::getWhere() will be skipped as the if-condition is not fulfilled when $conf['pidInList'] is 0 or empty. Only enableFields() will remain in where clause. SELECT cn_short_en FROM static_countries WHERE static_countries.deleted=0 Markus Klein wrote: I'm not sure why it obviously works with static_countries, but I've to investigate further. static_* tables are handled differently with pid_uid_flag flag.
  23. Markus Klein commented on patch set 3 01/22/12, 20:20

    Abandoned Solved by: https://review.typo3.org/7839