78260[FEATURE] Add configuration for convertable image extensions
Commit message
Review
-
Code review CR -1
- Garvin Hicking -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Resource/Processing/AbstractGraphicalTask.php2+9 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-93981-ConfigurationOptionForConvertableImageExtensions.rstnew+35 −0
Review log 1517
-
Philipp Kitzberger uploaded patch set 1 03/26/23, 12:09
-
core-ci voted on patch set 1 V +1 03/26/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39643
-
Chris Müller commented on patch set 1 CR -1 03/26/23, 17:20
At least a feature rst is needed: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html#changelog -
Philipp Kitzberger uploaded patch set 2
CR -1V +103/26/23, 19:08 -
Philipp Kitzberger commented on patch set 2 03/26/23, 19:10
Reply
DoneGood point. Added a rst file with a description of the change. Not 100% sure about the wording though. I'm open for any suggestion. -
core-ci voted on patch set 2 V +1 03/26/23, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39650
-
Benni Mack commented on patch set 2 03/27/23, 07:47
AbstractGraphicalTask.php:85How about we introduce a a assoc array $TYPO3_CONF_VARS['GFX']['processingImageTypes'] = ['jpg' => 'jpg', 'webp' => 'jpg', 'gif' => 'png'] If a key (= source file extension) is not given, we could then keep the filename if it's in the ```imagefile_ext``` list, or use a fallback to convert them to `png`. This way, we could also get rid of `thumbnails_png` which already is a similar behaviour to migrate gif/png to their respective files and also deprecate thumbnails_png? -
Philipp Kitzberger commented on patch set 2 03/27/23, 07:56
AbstractGraphicalTask.php:85Reply Unresolved> How about we introduce a a assoc array .. GFX/processingImageTypes .. > If a key (= source file extension) is not given, we could then keep the filename if it's in the imagefile_ext list Since the default ```imagefile_ext``` contains tiff and pdf as well that new assoc array would have to contain all of those too. But yeah, I like the idea. The fallback could be done by a key ```'*' => 'png'```. -
Garvin Hicking commented on patch set 2 09/18/23, 12:05
Adding myself as CC for possible progress in this, it touches an area of my proposed SVG-no-crop-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617 -
Garvin Hicking commented on patch set 2 11/26/24, 16:46
Do we maybe want to abandon this now that webp support is added "organically" to v13+? I'm afraid a "blank forward compatibility" approach like this will probably fail easily due to gdlib/imagemagick/graphicsmagick/mimetype lookups, so that we will probably always have to implement each new file format specifically. -
Chris Müller wrote 11/26/24, 18:19
Removed reviewer Chris Müller. -
Garvin Hicking commented on patch set 2 CR -1 12/20/24, 09:53
On it (may take a bit). Will try a few things with this one. I like the idea of using this feature to define defaults of image coversions. Also I might be able to fix a bug with wrong file extensions being used when converting non-web formats to web formats as a drive by. -
Garvin Hicking commented on patch set 2 12/21/24, 14:58
To proceed further, these two patches should be finished up first, as they touch similar areas and the tests are needed for refactoring: 87567: [BUGFIX] Ensure AVIF files are only written when format is supported | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87567 87581: [TASK] Add GraphicsMagick / ImageMagick f:image conversion tests | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87581 -
Garvin Hicking commented on patch set 2 01/02/25, 11:13
@typo3@kitze.net can you check if this patch works out for you? I've changed it at major points so I'm thinking if you don't agree to run under your name I'd put it out on its own :) -
Garvin Hicking commented on patch set 2 01/02/25, 11:14
Reply
(the changed parts are in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87582 proposed right now, so I wonder if I should merge it back into this one or leave it seperate) -
Benni Mack marked it work in progress 04/02/25, 05:55
-
Garvin Hicking abandoned the change 11/10/26, 10:56
outdated