Review main Merged

78269[TASK] Use the proper interface with willReturnCallback in EXT:core tests

Oliver Klee CR +2 V +2 Normal +77 −78 updated 03/27/23, 18:42

Commit message

- use parameter and return type declarations
- use the same parameter names as in the mocked method
- drop useless `self::anything()` calls
- drop `self::isType()` calls that duplicate the native type declarations

This improves code readability and type safety in the tests.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 56

  1. Oliver Klee uploaded patch set 1 03/27/23, 13:10

  2. core-ci voted on patch set 1 V +1 03/27/23, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39696

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/27/23, 14:04

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 03/27/23, 18:40

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 03/27/23, 18:42

  6. Nikita Hovratov merged patch set 2 03/27/23, 18:42