Review main Merged

78272[TASK] Harden willReturnCallback calls in some extension tests

Oliver Klee CR +2 V +2 Normal +39 −27 updated 04/13/23, 12:28

Commit message

- add parameter and return type declarations
- use the same parameter names as in the mocked methods
- use first-class callables
- replace `isType()` calls with parameter type declarations

… in the `willReturnCallback` callbacks in the unit tests of these
extensions:

- fluid
- form
- frontend
- impexp
- install
- seo

This improves code readability and type safety.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7