Review main Merged

78276[TASK] Update PHP dependencies

Wouter Wolters CR +2 V +2 Hard +187 −187 updated 03/29/23, 18:41

Commit message

This change updates the main TYPO3 code base
vendor/ directory to lock to latest packages
from our main dependencies, ready for the next
v12.x release, so the "non-composer mode"
has various updated dependencies shipped.

Used commands:
  composer update "symfony/*" "doctrine/*" -W

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Wouter Wolters uploaded patch set 1 03/27/23, 18:50

  2. Georg Ringer voted on patch set 1 CR +1 03/27/23, 18:51

  3. core-ci voted on patch set 1 V +1 03/27/23, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39717

  4. Stefan Bürk commented on patch set 1 CR -1 03/27/23, 19:08

  5. Christian Kuhn commented on patch set 1 03/27/23, 19:15

    for main, i'd prefer to raise the min-versions that exist in composer.json as much as possible, as well. for v11, we can't do that, though.
  6. Wouter Wolters commented on patch set 1 03/27/23, 19:22

    Reply

    I did it the same way as was done last time. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/77702
  7. core-ci voted on patch set 1 V -1 03/27/23, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39718

  8. core-ci voted on patch set 1 V +1 03/27/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39718

  9. Stefan Bürk voted on patch set 1 CR 0 03/27/23, 20:49

  10. Christian Kuhn commented on patch set 1 03/27/23, 21:27

    Reply

    ok, if my comment was stupid, ignore it. maybe we still want to raise lower-bounds for v12 lts, but not fully sure.
  11. Christian Kuhn voted on patch set 1 V +1 CR +1 03/29/23, 18:19

  12. Oliver Klee voted on patch set 1 V +1 CR +1 03/29/23, 18:33

  13. Christian Kuhn voted on patch set 1 V +2 CR +2 03/29/23, 18:41

  14. Christian Kuhn merged patch set 2 03/29/23, 18:41