Review main Merged

78278[TASK] Change return type of TextDescriptor::describeApplication

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 03/27/23, 20:31

Commit message

To prevent issues when upgrading to Symfony 6.3.x-dev the return type
of TextDescriptor::describeApplication is changed to void.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Wouter Wolters uploaded patch set 1 03/27/23, 19:27

  2. Wouter Wolters uploaded patch set 2 03/27/23, 19:44

  3. core-ci voted on patch set 1 V -1 03/27/23, 19:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39721

  4. Wouter Wolters uploaded patch set 3 03/27/23, 19:56

  5. Benni Mack voted on patch set 3 CR +1 03/27/23, 19:56

  6. Oliver Klee voted on patch set 3 CR +1 03/27/23, 20:01

  7. core-ci voted on patch set 2 V -1 03/27/23, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39722

  8. core-ci voted on patch set 3 V +1 03/27/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39724

  9. Benni Mack voted on patch set 3 V +1 03/27/23, 20:22

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 03/27/23, 20:31

  11. Andreas Kienast merged patch set 4 03/27/23, 20:31