7828[BUGFIX] Media element does not recognize short YouTube links
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
-
Verified V +2
- Xavier Perseguers +2
Files 1
Review log 7
-
Xavier Perseguers commented on patch set 1 03/06/12, 09:12
Do not submit - Is it only related to 4.6? If not this should go to master first and then be backported. - The commit message does not respect the rules (see wiki) and you have to reference the bugtracker entry - Above all: you have pushed a change to submodules which MUST not be part of this patch But thanks for digging into this problem anyway. -
Ernesto Baschny commented on patch set 2 03/06/12, 09:12
Looks good to me, but someone else must approve FYI, the patch should be applied to MASTER also, as the Media Wizard Provider *should* be also used there as soon as the "new MEDIA element from BLE" situation is fixed (see Issue #33357). So in this case I would propose to have it commited in a different order: - review and merge in 4.6 (like it has been started already) - have tags for Releases 4.5, 4.6, 4.7 (like patchset 2 already does) - as soon as it gets merged, cherry-pick into 4.5 and master so that it is also available there. -
Xavier Perseguers uploaded patch set 3 03/06/12, 09:12
-
Xavier Perseguers commented on patch set 3 V 0 03/06/12, 09:12
by team member; Looks good to me, approved -
Steffen Gebert uploaded patch set 2 03/06/12, 09:12
-
Steffen Gebert commented on patch set 2 03/06/12, 09:12
Verified; Looks good to me, but someone else must approve Patch is correct for 4.6. I'm unsure about 4.5 + 4.7. Please see BT entry. Wait with submitting, until we know about master! -
Xavier Perseguers merged patch set 3 03/06/12, 09:12