Review main Merged

78297[TASK] Deprecate TCA config MM_insert_fields

Christian Kuhn CR +2 V +2 Normal +148 −3 updated 03/28/23, 12:22

Commit message

"True" MM relations (intermediata table with uid_local
and uid_foreign columns, and no TCA for this table) are
still hard to configure in TYPO3. One reason is the
amount of TCA config options: It's often not clear
to developers which ones need to be set, and which ones
are optional or useless.

One of the 'useless' options is MM_insert_fields: It
allows setting a column in the intermediate table to a
configured value. Intermediate tables are transparent
in TYPO3: They are fully managed by the system, there
is not way to edit them within the framework. As such,
having an additional column within intermediate tables
that carry some value, is useless.

Looking at usages within extensions of MM_insert_fields,
it turns out developers typically confuse it with
MM_match_fields (this config is a story on its own).
Developers simply tend to set both MM_insert_fields and
MM_match_fields to the same value "to be sure".

The patch deprecates MM_insert_fields without
substitution in v12. TYPO3 v13 will actively remove
this config option from TCA.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7