Review main Merged

78312[BUGFIX] Apply overflow to not cut off FormEngine wizards

Andreas Kienast CR +2 V +2 Easy +6 −1 updated 03/29/23, 10:55

Commit message

Within `.form-group`, the elements `.panel` and `.panel-group` get a
visible overflow applied to not cut off FormEngine wizards, e.g. color
pickers.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 03/29/23, 06:17

  2. core-ci voted on patch set 1 V +1 03/29/23, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39798

  3. Stephan Großberndt updated the commit message in patch set 2 V +1 03/29/23, 07:24

  4. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/29/23, 07:28

  5. core-ci voted on patch set 2 V +1 03/29/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39803

  6. Jasmina Ließmann commented on patch set 2 V +1 CR +1 03/29/23, 10:39

    Tested on Win/Chrome: Display in flexform fields looks good. Display of the last color picker in 'Extension Configuration' > 'styleguide' > tab 'color' is cut off (because of less space afterwards). But that wasn't the scope of the patch I guess.
  7. Andreas Kienast commented on patch set 2 V +2 CR +2 03/29/23, 10:55

    Reply

    That's nasty, but you're right, that's not the scope of this patch. The color picker is not able to determine the available space and always renders below fields.
  8. Andreas Kienast merged patch set 3 03/29/23, 10:55