Review main Merged

78313[BUGFIX] Use document language for flatpickr

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 03/29/23, 17:52

Commit message

FormEngine's date picker now uses the document's HTML `lang`
attribute to determine its language to use.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Henrik Ziegenhain +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Andreas Kienast uploaded patch set 1 03/29/23, 07:08

  2. Andreas Kienast uploaded patch set 2 03/29/23, 07:12

  3. core-ci voted on patch set 1 V +1 03/29/23, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39800

  4. core-ci voted on patch set 2 V -1 03/29/23, 07:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39802

  5. Andreas Kienast uploaded patch set 3 V -1 03/29/23, 07:40

  6. Henrik Ziegenhain voted on patch set 3 CR +1 03/29/23, 07:44

  7. Andreas Kienast uploaded patch set 4 CR +1 03/29/23, 07:46

  8. core-ci voted on patch set 3 V +1 03/29/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39804

  9. core-ci voted on patch set 4 V +1 03/29/23, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39805

  10. Henrik Ziegenhain voted on patch set 4 CR +1 03/29/23, 08:43

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 03/29/23, 09:18

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 03/29/23, 17:52

  13. Andreas Kienast merged patch set 5 03/29/23, 17:52