Review main Merged

78314[BUGFIX] Handle potentially aliased start module

Andreas Kienast CR +2 V +2 Easy +2 −0 updated 03/29/23, 16:30

Commit message

If BE_USER->uc['startModule'] is a "legacy" alias value, resolving the
start module in the BackendController fails, leading to a recursively
rendered backend.

The ModuleProvider API is now used to resolve the according backend
module and using its original module name.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Andreas Kienast uploaded patch set 1 03/29/23, 08:18

  2. Benni Mack commented on patch set 1 03/29/23, 08:19

    BackendController.php:264

    we should do the same on the "startModuleOnFirstLogin" feature IMHO a few lines above
  3. core-ci voted on patch set 1 V +1 03/29/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39806

  4. Andreas Kienast commented on patch set 1 03/29/23, 09:25

    BackendController.php:264 Reply

    Ack, albeit that's an extremely rare case something goes off here. `startModuleOnFirstLogin` is only set when using the "switch user" feature and takes effect once a user leaves the SU mode.
  5. Andreas Kienast uploaded patch set 2 V +1 03/29/23, 09:31

  6. Andreas Kienast commented on patch set 2 CR -1 03/29/23, 09:34

    found a more generic approach
  7. Andreas Kienast uploaded patch set 3 CR -1 03/29/23, 09:36

  8. Andreas Kienast commented on patch set 3 03/29/23, 09:36

    BackendController.php:264 Reply

    Done
  9. core-ci voted on patch set 2 V +1 03/29/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39812

  10. core-ci voted on patch set 3 V +1 03/29/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39813

  11. Georg Ringer voted on patch set 3 CR +1 03/29/23, 12:01

  12. Thomas Hohn voted on patch set 3 CR +1 03/29/23, 12:01

  13. Benni Mack commented on patch set 3 V +1 CR +1 03/29/23, 15:33

    Thank you!
  14. Christian Kuhn voted on patch set 3 V +2 CR +2 03/29/23, 16:30

  15. Christian Kuhn merged patch set 4 03/29/23, 16:30