78314[BUGFIX] Handle potentially aliased start module
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Thomas Hohn +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Andreas Kienast uploaded patch set 1 03/29/23, 08:18
-
Benni Mack commented on patch set 1 03/29/23, 08:19
-
core-ci voted on patch set 1 V +1 03/29/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39806
-
Andreas Kienast commented on patch set 1 03/29/23, 09:25
BackendController.php:264ReplyAck, albeit that's an extremely rare case something goes off here. `startModuleOnFirstLogin` is only set when using the "switch user" feature and takes effect once a user leaves the SU mode. -
Andreas Kienast uploaded patch set 2
V +103/29/23, 09:31 -
Andreas Kienast commented on patch set 2 CR -1 03/29/23, 09:34
found a more generic approach -
Andreas Kienast uploaded patch set 3
CR -103/29/23, 09:36 -
Andreas Kienast commented on patch set 3 03/29/23, 09:36
BackendController.php:264ReplyDone -
core-ci voted on patch set 2 V +1 03/29/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39812
-
core-ci voted on patch set 3 V +1 03/29/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39813
-
Georg Ringer voted on patch set 3 CR +1 03/29/23, 12:01
-
Thomas Hohn voted on patch set 3 CR +1 03/29/23, 12:01
-
Benni Mack commented on patch set 3 V +1 CR +1 03/29/23, 15:33
Thank you! -
Christian Kuhn voted on patch set 3 V +2 CR +2 03/29/23, 16:30
-
Christian Kuhn merged patch set 4 03/29/23, 16:30
BackendController.php:264