Review main Merged

78330[BUGFIX] Do not send table wizard fields in payload

Andreas Kienast CR +2 V +2 Easy +21 −21 updated 05/09/23, 07:18

Commit message

The fields used in the table wizard are only used for internal handling
to be able to compose the final table markup sent to DataHandler. The
"management fields" are not interesting on server side and therefore
their respective `name` attributes are removed to avoid sending
potentially huge, superfluous data.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Torben Hansen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1621

  1. Andreas Kienast uploaded patch set 1 03/30/23, 08:44

  2. Andreas Kienast uploaded patch set 2 03/30/23, 08:48

  3. Stefan Neufeind commented on patch set 2 CR +1 03/30/23, 08:53

    Nice catch. Didn't think it was this "easy". Fine by reading.
  4. Torben Hansen voted on patch set 2 V +1 CR +1 03/30/23, 09:14

  5. core-ci voted on patch set 2 V -1 03/30/23, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39858

  6. core-ci voted on patch set 1 V -1 03/30/23, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39857

  7. Oliver Klee commented on patch set 2 03/30/23, 09:57

    It looks like we'll need to adapt an acceptance test.
  8. Andreas Kienast commented on patch set 2 CR -1 03/30/23, 10:48

    on it
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 03/30/23, 11:05

  10. Andreas Kienast commented on patch set 3 03/30/23, 11:06

    Reply

    Done
  11. core-ci voted on patch set 3 V +1 03/30/23, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39862

  12. Torben Hansen voted on patch set 3 V +1 CR +1 03/30/23, 11:42

  13. Benni Mack updated the commit message in patch set 4 CR +1 V +1 05/03/23, 09:41

  14. Torben Hansen commented on patch set 4 V +1 CR +1 05/04/23, 13:51

    It think we should also add this to v11
  15. Benni Mack voted on patch set 4 V +1 CR +1 05/09/23, 06:10

  16. Andreas Kienast commented on patch set 4 CR +2 05/09/23, 06:13

    waiting for CI
  17. core-ci voted on patch set 4 V -1 05/09/23, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41685

  18. core-ci voted on patch set 4 V +1 05/09/23, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41685

  19. Andreas Kienast voted on patch set 4 V +2 05/09/23, 06:30

  20. Andreas Kienast merged patch set 5 05/09/23, 06:30

  21. Stefan Neufeind voted on patch set 5 CR +1 05/09/23, 07:18