78339[TASK] Clean up avatar class
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Markus Klein +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2329
Show 34 earlier messages
-
Christian Eßl uploaded patch set 1 03/31/23, 15:39
-
Christian Eßl updated the commit message in patch set 2 03/31/23, 15:41
-
core-ci voted on patch set 2 V +1 03/31/23, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39909
-
Nikita Hovratov commented on patch set 2 03/31/23, 15:50
-
Christian Eßl uploaded patch set 3
V +103/31/23, 15:54 -
Christian Eßl commented on patch set 3 03/31/23, 15:54
Avatar.php:120ReplyDone -
core-ci voted on patch set 3 V +1 03/31/23, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39910
-
core-ci voted on patch set 1 V +1 03/31/23, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39908
-
Markus Klein commented on patch set 3 CR +1 03/31/23, 19:15
fix necessary for v11 too? -
Christian Kuhn commented on patch set 3 CR -1 04/01/23, 02:59
Avatar.php:118put that into __construct() and skip the if(). -
Christian Eßl uploaded patch set 4
CR +1V +104/01/23, 08:56 -
Christian Eßl commented on patch set 4 04/01/23, 08:56
Avatar.php:118ReplyDone -
core-ci voted on patch set 4 V +1 04/01/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39933
-
Oli Bartsch commented on patch set 4 CR -1 04/03/23, 10:48
DefaultAvatarProvider.php:40We should use the null coalescing operator here to prevent an undefined array key warning. -
Markus Klein voted on patch set 4 CR +1 04/03/23, 11:24
-
Markus Klein commented on patch set 4 04/03/23, 11:26
DefaultAvatarProvider.php:40ReplyIMO that's not strictly necessary here. If one passes an incomplete/invalid beuser "model" here, then a warning/error totally fine. -
Christian Eßl rebased onto patch set 5
CR +1V +104/26/23, 09:42 -
Christian Eßl commented on patch set 5 04/26/23, 09:45
DefaultAvatarProvider.php:40ReplyI also think we can always safely assume, that a complete backend user array is passed here. -
core-ci voted on patch set 5 V +1 04/26/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41245
-
Andreas Kienast voted on patch set 5 V +1 CR +1 04/26/23, 09:50
-
Markus Klein voted on patch set 5 V +1 CR +1 04/26/23, 10:08
-
Christian Kuhn commented on patch set 5 CR -1 04/27/23, 10:44
DefaultAvatarProvider.php:40Replydon't add magic to the "count" field of relations: this field is notoriously outdated, there isn't even a "fixer" to update to current state. we should get rid of it entirely. -
Markus Klein commented on patch set 5 V 0 CR 0 04/27/23, 10:49
DefaultAvatarProvider.php:40ReplyOh... you are right of course. I totally missed that this is of course IRRE. I thought the fields holds the file uid directly. -
Christian Kuhn uploaded patch set 6
CR +1V +104/27/23, 10:54 -
Christian Kuhn commented on patch set 6 V +1 CR +1 04/27/23, 10:55
DefaultAvatarProvider.php:40ReplyDone: Removed that hunk. -
Markus Klein voted on patch set 6 V +1 CR +1 04/27/23, 10:58
-
core-ci voted on patch set 6 V +1 04/27/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41268
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 04/27/23, 12:56
-
Nikita Hovratov merged patch set 7 04/27/23, 12:56
Avatar.php:120