Review main Abandoned

78343[POC] PersistedAliasMapper: Generate record links without extra database lookup

Christoph Lehmann CR 0 V 0 Easy +10 −0 updated 04/10/23, 20:34

Commit message

By passing a slug in link parameters instead the record uid, no extra database
lookup is needed.

People might use integer only slugs so this uses the prefix 'SLUG:'

Link parameters:

Old: ?id=10&tx_news_pi1[controller]=News&tx_news_pi1[action]=detail&tx_news_pi1[news]=1
New: ?id=10&tx_news_pi1[controller]=News&tx_news_pi1[action]=detail&tx_news_pi1[news]=SLUG:slug-of-the-news

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 35

  1. Christoph Lehmann uploaded patch set 1 03/31/23, 19:47

  2. core-ci voted on patch set 1 V +1 03/31/23, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39914

  3. Christoph Lehmann rebased onto patch set 2 V +1 04/10/23, 20:18

  4. core-ci voted on patch set 2 V +1 04/10/23, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40422

  5. Christoph Lehmann abandoned the change 04/10/23, 20:34