78344[TASK] Superfluous SQL query in language menu
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1217
-
Christoph Lehmann uploaded patch set 1 03/31/23, 20:23
-
core-ci voted on patch set 1 V +1 03/31/23, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39915
-
Christoph Lehmann updated the commit message in patch set 2
V +104/02/23, 14:26 -
core-ci voted on patch set 2 V +1 04/02/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39988
-
Benni Mack voted on patch set 2 V +1 CR +1 04/03/23, 13:19
-
Oli Bartsch commented on patch set 2 04/04/23, 09:47
-
Oli Bartsch commented on patch set 2 04/04/23, 10:10
AbstractMenuContentObject.php:571ReplyWe might even use a one-liner: ($tsfe->page['_TRANSLATION_SOURCE'] ?? null)?->toArray(true) ?? $tsfe->page; -
Christoph Lehmann uploaded patch set 3
CR +1V +104/04/23, 17:50 -
Christoph Lehmann commented on patch set 2 04/04/23, 17:52
AbstractMenuContentObject.php:571ReplyI'm fine with the oneline. The instanceof has a bad touch, because it possibly eats an Exception and then leads to wrong behaviour. -
core-ci voted on patch set 3 V +1 04/04/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40110
-
Christoph Lehmann uploaded patch set 4
V +104/10/23, 20:18 -
Christoph Lehmann commented on patch set 5 04/10/23, 20:31
Published edit on patch set 4. -
core-ci voted on patch set 4 V +1 04/10/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40423
-
core-ci voted on patch set 5 V +1 04/10/23, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40431
-
Oli Bartsch voted on patch set 5 V +1 CR +1 04/11/23, 06:57
-
Benni Mack voted on patch set 5 V +2 CR +2 04/11/23, 09:46
-
Benni Mack merged patch set 6 04/11/23, 09:46
AbstractMenuContentObject.php:571