Review main Merged

78345[TASK] Avoid superfluous SQL query in ContentObjectRenderer

Christoph Lehmann CR +2 V +2 Easy +10 −1 updated 04/03/23, 13:19

Commit message

Don't check accessibility to current page and if its
content should be rendered twice. This is already done
in the TypoScriptFrontendController.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Christoph Lehmann uploaded patch set 1 03/31/23, 21:10

  2. core-ci voted on patch set 1 V +1 03/31/23, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39916

  3. Christoph Lehmann uploaded patch set 2 V +1 03/31/23, 21:20

  4. Christoph Lehmann updated the commit message in patch set 3 03/31/23, 21:26

  5. core-ci voted on patch set 2 V +1 03/31/23, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39917

  6. core-ci voted on patch set 3 V +1 03/31/23, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39918

  7. Markus Klein commented on patch set 3 03/31/23, 21:58

    ContentObjectRenderer.php:5563

    Just reading this code piece here, this is not "apparent" to me. Please describe this a bit more, why this check is okay/sufficient
  8. Christoph Lehmann uploaded patch set 4 V +1 03/31/23, 22:55

  9. Christoph Lehmann commented on patch set 4 03/31/23, 22:55

    ContentObjectRenderer.php:5563 Reply

    Done
  10. core-ci voted on patch set 4 V +1 03/31/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39920

  11. Christoph Lehmann updated the commit message in patch set 5 V +1 04/02/23, 14:24

  12. core-ci voted on patch set 5 V +1 04/02/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39986

  13. Markus Klein voted on patch set 5 V +1 CR +1 04/03/23, 11:39

  14. Andreas Kienast voted on patch set 5 CR +1 04/03/23, 13:19

  15. Benni Mack commented on patch set 5 V +2 CR +2 04/03/23, 13:19

    great stuff!
  16. Benni Mack merged patch set 6 04/03/23, 13:19