Review main Merged

78349[TASK] Have types in extbase ClassSchema related classes

Alexander Schnitzler CR +2 V +2 Normal +24 −89 updated 12/09/24, 12:01

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1418

  1. Alexander Schnitzler uploaded patch set 1 04/01/23, 08:40

  2. core-ci voted on patch set 1 V +1 04/01/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39932

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/01/23, 08:54

  4. Alexander Schnitzler wrote 04/01/23, 08:55

    Topic set to extbase
  5. Alexander Schnitzler abandoned the change 04/01/23, 17:12

  6. Christian Kuhn restored the change 12/09/24, 11:15

  7. Christian Kuhn uploaded patch set 2 CR +1 V +1 12/09/24, 11:17

  8. Oliver Klee commented on patch set 2 12/09/24, 11:22

    ClassSchema.php:60

    ```suggestion /** @var class-string */ private string $className; ```
  9. core-ci voted on patch set 2 V +1 12/09/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70805

  10. Christian Kuhn uploaded patch set 3 V +1 12/09/24, 11:27

  11. Christian Kuhn commented on patch set 3 12/09/24, 11:29

    ClassSchema.php:60 Reply

    Done
  12. Christian Kuhn uploaded patch set 4 12/09/24, 11:30

  13. core-ci voted on patch set 3 V +1 12/09/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70806

  14. core-ci voted on patch set 4 V +1 12/09/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70807

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 12/09/24, 11:37

  16. Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/09/24, 11:38

  17. Christian Kuhn voted on patch set 4 CR +2 V +2 12/09/24, 12:01

  18. Christian Kuhn merged patch set 5 12/09/24, 12:01