Review main Merged

78350[TASK] Add initiator to <f:sanitize.html> view helper invocation

Oliver Hader CR +2 V +2 Normal +106 −1 updated 04/04/23, 18:31

Commit message

With this update, whenever the `<f:sanitize.html>` view helper is
invoked, the initiator reference will be included in the log. This
will help to quickly identify which class or component triggered
the sanitization process and take necessary actions if needed.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1418

  1. Oliver Hader uploaded patch set 1 04/01/23, 09:38

  2. core-ci voted on patch set 1 V -1 04/01/23, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39934

  3. Oliver Hader uploaded patch set 2 V -1 04/01/23, 16:13

  4. core-ci voted on patch set 2 V +1 04/01/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39940

  5. Oliver Klee commented on patch set 2 CR -1 04/03/23, 08:02

    When reading the commit message (without reading the code), I don't know what an initiator in this context is, and why we'd want to log this. Could you please elaborate?
  6. Oliver Hader updated the commit message in patch set 3 CR -1 V +1 04/03/23, 14:00

  7. Oliver Hader commented on patch set 3 04/03/23, 14:04

    Reply

    I tried to rephrase that a little bit. I was under the impression that the concept of an "initiator" would be known - for instance it's similar to in the Chrome Browser console... Anyway, in case you're still not happy with the explanation in the commit message, I kindly ask you to provide a better suggestion. You can easily use the "✏️ edit" button below the commit message to change that. Thanks!
  8. Christian Kuhn commented on patch set 3 04/03/23, 14:05

    DefaultSanitizerBuilderTest.php:202

    please avoid makeInstance in tests. go with $this->get() or new().
  9. core-ci voted on patch set 3 V +1 04/03/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40019

  10. Oliver Hader commented on patch set 3 04/03/23, 14:18

    DefaultSanitizerBuilderTest.php:202 Reply

    Done
  11. Oliver Hader uploaded patch set 4 V +1 04/03/23, 14:18

  12. Oliver Hader commented on patch set 4 04/03/23, 14:25

    DefaultSanitizerBuilderTest.php:202 Reply

    Follow-up: Replacing remaining occurrences in `main` branch → https://review.typo3.org/c/Packages/TYPO3.CMS/+/78380
  13. core-ci voted on patch set 4 V +1 04/03/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40021

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 04/03/23, 14:31

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 04/03/23, 15:13

  16. Oliver Klee wrote 04/03/23, 16:34

    Removed reviewer Oliver Klee.
  17. Oliver Hader commented on patch set 4 V +2 CR +2 04/04/23, 18:30

    Thx folks!
  18. Oliver Hader merged patch set 5 04/04/23, 18:31