Review main Merged

78352[BUGFIX] Remove visual gap from hidden CEs on page module

Andreas Nedbal CR +2 V +2 Easy +11 −2 updated 04/03/23, 10:33

Commit message

Hidden content elements are still present in the document flow
but just have a height of 0 causing the uniform spacing with
collapsed margins to fail. We remove the hidden element from
the document flow to prevent this.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Andreas Nedbal uploaded patch set 1 04/01/23, 18:32

  2. core-ci voted on patch set 1 V +1 04/01/23, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39941

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 04/01/23, 21:38

  4. Torben Hansen voted on patch set 1 V +1 CR +1 04/02/23, 12:04

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 04/03/23, 10:33

  6. Oli Bartsch merged patch set 2 04/03/23, 10:33