78355[BUGFIX] Fix resolving of page record titles in Clipboard
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Torben Hansen +1
-
Verified V +2 Done
- Oli Bartsch +2
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1520
-
Andreas Nedbal uploaded patch set 1 04/01/23, 21:39
-
Andreas Nedbal updated the commit message in patch set 2 04/01/23, 21:40
-
core-ci voted on patch set 2 V +1 04/01/23, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39949
-
core-ci voted on patch set 1 V +1 04/01/23, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39948
-
Torben Hansen commented on patch set 2 V -1 04/02/23, 12:27
This does not fix the bug reported in #99826. I debugged the reported problem and this is caused by `TYPO3\CMS\Backend\Clipboard\Clipboard::confirmMsgText()` line 591. There, the sitename is selected if the table is `pages`. I currently unsure, why the sitename is chosen in this case, since the current page title can actually be evaluated at this point. -
Andreas Nedbal commented on patch set 2 04/02/23, 12:46
Reply
I see, I tested the clipboard functionality and ended up fixing the first bug that I came across, which actually is reported as #99825. I'll look into why the confirm message is wrong. -
Andreas Nedbal uploaded patch set 3
V +104/02/23, 13:47 -
Andreas Nedbal commented on patch set 3 04/02/23, 13:50
Reply
Done -
core-ci voted on patch set 3 V +1 04/02/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39983
-
Andreas Nedbal updated the commit message in patch set 4
V +104/02/23, 14:06 -
core-ci voted on patch set 4 V +1 04/02/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39985
-
Torben Hansen commented on patch set 4 V +1 CR +1 04/03/23, 07:36
The record title fix should IMO also be backported to v11, since it is wrong there since #94731 -
Oli Bartsch commented on patch set 4 CR -1 04/03/23, 08:57
Please let's split the patch into two separate patches. This one fixing #99826 with being backported to 11.5 and another patch fixing #99825 for main only. -
Andreas Nedbal uploaded patch set 5
CR +1V +104/03/23, 16:00 -
Andreas Nedbal commented on patch set 4 04/03/23, 16:04
Reply
Done -
core-ci voted on patch set 5 V +1 04/03/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40029
-
Oli Bartsch voted on patch set 5 V +1 CR +1 04/03/23, 16:27
-
Torben Hansen voted on patch set 5 V +1 CR +1 04/03/23, 16:40
-
Oli Bartsch voted on patch set 5 V +2 CR +2 04/03/23, 23:05
-
Oli Bartsch merged patch set 6 04/03/23, 23:05