Review main Merged

78355[BUGFIX] Fix resolving of page record titles in Clipboard

Andreas Nedbal CR +2 V +2 Easy +3 −3 updated 04/03/23, 23:05

Commit message

This caused page titles in copy/cut functionality to not
be resolved and instead display the site title as a fallback.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Andreas Nedbal uploaded patch set 1 04/01/23, 21:39

  2. Andreas Nedbal updated the commit message in patch set 2 04/01/23, 21:40

  3. core-ci voted on patch set 2 V +1 04/01/23, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39949

  4. core-ci voted on patch set 1 V +1 04/01/23, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39948

  5. Torben Hansen commented on patch set 2 V -1 04/02/23, 12:27

    This does not fix the bug reported in #99826. I debugged the reported problem and this is caused by `TYPO3\CMS\Backend\Clipboard\Clipboard::confirmMsgText()` line 591. There, the sitename is selected if the table is `pages`. I currently unsure, why the sitename is chosen in this case, since the current page title can actually be evaluated at this point.
  6. Andreas Nedbal commented on patch set 2 04/02/23, 12:46

    Reply

    I see, I tested the clipboard functionality and ended up fixing the first bug that I came across, which actually is reported as #99825. I'll look into why the confirm message is wrong.
  7. Andreas Nedbal uploaded patch set 3 V +1 04/02/23, 13:47

  8. Andreas Nedbal commented on patch set 3 04/02/23, 13:50

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 04/02/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39983

  10. Andreas Nedbal updated the commit message in patch set 4 V +1 04/02/23, 14:06

  11. core-ci voted on patch set 4 V +1 04/02/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39985

  12. Torben Hansen commented on patch set 4 V +1 CR +1 04/03/23, 07:36

    The record title fix should IMO also be backported to v11, since it is wrong there since #94731
  13. Oli Bartsch commented on patch set 4 CR -1 04/03/23, 08:57

    Please let's split the patch into two separate patches. This one fixing #99826 with being backported to 11.5 and another patch fixing #99825 for main only.
  14. Andreas Nedbal uploaded patch set 5 CR +1 V +1 04/03/23, 16:00

  15. Andreas Nedbal commented on patch set 4 04/03/23, 16:04

    Reply

    Done
  16. core-ci voted on patch set 5 V +1 04/03/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40029

  17. Oli Bartsch voted on patch set 5 V +1 CR +1 04/03/23, 16:27

  18. Torben Hansen voted on patch set 5 V +1 CR +1 04/03/23, 16:40

  19. Oli Bartsch voted on patch set 5 V +2 CR +2 04/03/23, 23:05

  20. Oli Bartsch merged patch set 6 04/03/23, 23:05