Review main Abandoned

78372[TASK] PageRepository: Use local variable for runtimeCache

Christoph Lehmann CR 0 V 0 Easy +6 −2 updated 04/10/23, 20:28

Commit message

The function getRuntimeCache() is possibly called a few hundred times.

By using a local variable it's faster.

This also removes the unused variable $workspaceId.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 69

  1. Christoph Lehmann uploaded patch set 1 04/02/23, 18:56

  2. Christoph Lehmann uploaded patch set 2 04/02/23, 18:58

  3. core-ci voted on patch set 2 V -1 04/02/23, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39994

  4. core-ci voted on patch set 1 V -1 04/02/23, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39993

  5. Christoph Lehmann uploaded patch set 3 V -1 04/02/23, 20:44

  6. core-ci voted on patch set 3 V -1 04/02/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39995

  7. Andreas Kienast commented on patch set 3 04/03/23, 06:58

    Do you have any metric how much faster it is?
  8. Christian Kuhn commented on patch set 3 CR -1 04/03/23, 07:57

    this will not make a measurable difference: cacheManager is a singleton and returned early in makeInstance, getCache() is a direct array lookup.
  9. Christoph Lehmann abandoned the change 04/10/23, 20:28