78372[TASK] PageRepository: Use local variable for runtimeCache
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 69
-
Christoph Lehmann uploaded patch set 1 04/02/23, 18:56
-
Christoph Lehmann uploaded patch set 2 04/02/23, 18:58
-
core-ci voted on patch set 2 V -1 04/02/23, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39994
-
core-ci voted on patch set 1 V -1 04/02/23, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39993
-
Christoph Lehmann uploaded patch set 3
V -104/02/23, 20:44 -
core-ci voted on patch set 3 V -1 04/02/23, 21:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39995
-
Andreas Kienast commented on patch set 3 04/03/23, 06:58
Do you have any metric how much faster it is? -
Christian Kuhn commented on patch set 3 CR -1 04/03/23, 07:57
this will not make a measurable difference: cacheManager is a singleton and returned early in makeInstance, getCache() is a direct array lookup. -
Christoph Lehmann abandoned the change 04/10/23, 20:28