Review main Merged

78377[TASK] Have SilentConfigurationUpgradeServiceTest functionals

Christian Kuhn CR +2 V +2 Expert +753 −990 updated 04/03/23, 13:26

Commit message

Turns existing unit tests into functionals, making
them more concise, avoids mocking parties, and
makes them better maintainable.

SilentConfigurationUpgradeService is slightly
cleaned up along the way, together with a minor
fix regarding a missing BE/lang/debug removal,
which was now found by the functional tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5