Review main Merged

78378[TASK] Remove AbstractPluginTest

Christian Kuhn CR +2 V +2 Hard +0 −340 updated 04/03/23, 14:45

Commit message

AbstractPlugin ("Pi1" FE plugins) has been
marked as "not maintained anymore" a while
ago.

The unit tests are a heavily mocking aweful
mess, most of them look at details that are
obvious reading the implementation. The
central topics like the ContentObjectRenderer
have unit tests on their own to sort out details.

AbstractPlugin may see a final deprecation
and there are little code changes in general.

The patch removes the "unit" tests to reduce
maintenance nightmares in this area, the tests
don't add much value.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1