Review main Merged

78380[TASK] Avoid using GeneralUtility::makeInstance in tests

Oliver Hader CR +2 V +2 Easy +2 −3 updated 04/03/23, 14:45

Commit message

Replace `GeneralUtility::makeInstance` with `new` statement.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 04/03/23, 14:24

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 04/03/23, 14:25

  3. Oliver Klee voted on patch set 1 V +1 CR +1 04/03/23, 14:31

  4. core-ci voted on patch set 1 V +1 04/03/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40022

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 04/03/23, 14:45

  6. Oli Bartsch merged patch set 2 04/03/23, 14:45