Review main Merged

78381[BUGFIX] Fix PagesWithoutDescriptionDataProvider

Oli Bartsch CR +2 V +2 Easy +5 −1 updated 04/06/23, 19:01

Commit message

Add the fields "perms_user" and "perms_group"
to the custom database query, since they are
required by calcPerms() to properly calculate
page permissions for non-admin users.

Additionally an early return is added, which
prevents fetching any page in case the user
is not allowed to edit them at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Sybille Peters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Oli Bartsch uploaded patch set 1 04/03/23, 15:19

  2. Oliver Klee voted on patch set 1 CR +1 04/03/23, 15:21

  3. core-ci voted on patch set 1 V +1 04/03/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40023

  4. Sybille Peters commented on patch set 1 V -1 04/04/23, 06:30

    With the patch I now get no result with admin user too (and with non-admin user). I tested without the patch: I see results for "Pages missing Meta Description" if logged in as admin user.
  5. Sybille Peters commented on patch set 1 04/04/23, 06:36

    The problem I reported in the issue was that the user sees no results even though he has permissions. What is being fixed here are additional permission checks (which are probably necessary but do not fix that problem). see also checks in linkvalidator where this is similar.

    PagesWithoutDescriptionDataProvider.php:46

    Should probably check if BE user is not admin here.
  6. Oli Bartsch uploaded patch set 2 CR +1 V +1 04/04/23, 08:58

  7. Oli Bartsch commented on patch set 2 04/04/23, 09:00

    Reply

    Done

    Reply

    Done

    PagesWithoutDescriptionDataProvider.php:46 Reply

    This check is done by the method. I just forgot the negation.
  8. core-ci voted on patch set 2 V +1 04/04/23, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40061

  9. Sybille Peters commented on patch set 2 V +1 04/04/23, 09:15

    looking good (for previous testcase with admin and non-admin user) 😊
  10. Jochen Roth voted on patch set 2 V +1 CR +1 04/06/23, 08:22

  11. Oliver Klee voted on patch set 2 CR +1 04/06/23, 08:25

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 04/06/23, 19:01

  13. Christian Kuhn merged patch set 3 04/06/23, 19:01