78384[BUGFIX] Use proper type for recovery emails
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Torben Hansen +1
-
Verified V +2 Done
- Oliver Hader +2
- Torben Hansen +1
Issues 1
Files 2
Review log 1619
-
Andreas Nedbal uploaded patch set 1 04/03/23, 17:00
-
Andreas Nedbal rebased onto patch set 2 04/03/23, 17:02
-
core-ci voted on patch set 1 V +1 04/03/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40031
-
core-ci voted on patch set 2 V +1 04/03/23, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40033
-
Oliver Klee voted on patch set 2 CR +1 04/03/23, 18:25
-
Torben Hansen commented on patch set 2 04/05/23, 16:48
-
Stefan Bürk commented on patch set 2 CR -1 04/06/23, 17:05
RecoveryService.php:89ReplyMhh, temp -1 to check this (not catching the unused import) -
Andreas Nedbal uploaded patch set 3
CR +1V +104/19/23, 16:27 -
Andreas Nedbal commented on patch set 3 04/19/23, 16:29
RecoveryService.php:89ReplyIt has been a while since the last reply, so I went ahead and removed the unused import now. -
Stefan Bürk commented on patch set 3 04/19/23, 16:30
RecoveryService.php:89Replysadly, just talked with torben to check this today. -
core-ci voted on patch set 3 V +1 04/19/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40922
-
Stefan Bürk commented on patch set 3 04/19/23, 16:57
RecoveryService.php:89ReplyThe class got not removed, because two methods have "email" in the method docblocks. See: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2814 -
Oliver Hader voted on patch set 3 CR +1 04/19/23, 17:11
-
Torben Hansen voted on patch set 3 V +1 CR +1 04/19/23, 17:13
-
Markus Klein voted on patch set 3 V +1 CR +1 04/25/23, 11:55
-
Benni Mack updated the commit message in patch set 4
CR +1V +105/03/23, 09:48 -
Torben Hansen voted on patch set 4 V +1 CR +1 05/03/23, 10:43
-
Oliver Hader voted on patch set 4 V +2 CR +2 05/03/23, 13:11
-
Oliver Hader merged patch set 5 05/03/23, 13:11
RecoveryService.php:89