Review main Merged

78384[BUGFIX] Use proper type for recovery emails

Andreas Nedbal CR +2 V +2 Easy +4 −5 updated 05/03/23, 13:11

Commit message

RecoveryService::prepareMail creates a FluidEmail, but
returns it as Symfony\Component\Mime\Email. Setting the
signature to the proper type, which also is used in the
SendRecoveryEmailEvent, allows easier adjustment of the
sent email.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Torben Hansen +1

Issues 1

Files 2

Review log 1619

  1. Andreas Nedbal uploaded patch set 1 04/03/23, 17:00

  2. Andreas Nedbal rebased onto patch set 2 04/03/23, 17:02

  3. core-ci voted on patch set 1 V +1 04/03/23, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40031

  4. core-ci voted on patch set 2 V +1 04/03/23, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40033

  5. Oliver Klee voted on patch set 2 CR +1 04/03/23, 18:25

  6. Torben Hansen commented on patch set 2 04/05/23, 16:48

    RecoveryService.php:89

    I reviewed and tested the patch and it works fine. There is now however an unused import of `Symfony\Component\Mime\Email` in this class. No idea, why this slipped through CI, but I think it should be removed.
  7. Stefan Bürk commented on patch set 2 CR -1 04/06/23, 17:05

    RecoveryService.php:89 Reply

    Mhh, temp -1 to check this (not catching the unused import)
  8. Andreas Nedbal uploaded patch set 3 CR +1 V +1 04/19/23, 16:27

  9. Andreas Nedbal commented on patch set 3 04/19/23, 16:29

    RecoveryService.php:89 Reply

    It has been a while since the last reply, so I went ahead and removed the unused import now.
  10. Stefan Bürk commented on patch set 3 04/19/23, 16:30

    RecoveryService.php:89 Reply

    sadly, just talked with torben to check this today.
  11. core-ci voted on patch set 3 V +1 04/19/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40922

  12. Stefan Bürk commented on patch set 3 04/19/23, 16:57

    RecoveryService.php:89 Reply

    The class got not removed, because two methods have "email" in the method docblocks. See: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/2814
  13. Oliver Hader voted on patch set 3 CR +1 04/19/23, 17:11

  14. Torben Hansen voted on patch set 3 V +1 CR +1 04/19/23, 17:13

  15. Markus Klein voted on patch set 3 V +1 CR +1 04/25/23, 11:55

  16. Benni Mack updated the commit message in patch set 4 CR +1 V +1 05/03/23, 09:48

  17. Torben Hansen voted on patch set 4 V +1 CR +1 05/03/23, 10:43

  18. Oliver Hader voted on patch set 4 V +2 CR +2 05/03/23, 13:11

  19. Oliver Hader merged patch set 5 05/03/23, 13:11