Review main Merged

78433[TASK] Drop handling for non existent contentNavigationSwitcher

Benjamin Kott CR +2 V +2 Easy +6 −21 updated 04/04/23, 08:12

Commit message

The handling was introduced in [1] to have a resizable navigation area.
With the introduction of a generalized Lit component, the handling was
incompletely removed in [2].

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/67511
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Benjamin Kott uploaded patch set 1 04/04/23, 06:59

  2. core-ci voted on patch set 1 V +1 04/04/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40054

  3. Christian Kuhn commented on patch set 1 04/04/23, 07:09

    any idea what it was supposed to do or how it was used in the past? maybe some hint in the commit message "structure was used in the past for this and has bee obsoleted with that"?
  4. Andreas Kienast updated the commit message in patch set 2 V +1 04/04/23, 07:26

  5. core-ci voted on patch set 2 V +1 04/04/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40055

  6. Benni Mack commented on patch set 2 V +1 CR +1 04/04/23, 08:05

    Thanks for providing more info, wondered the same as lolli
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 04/04/23, 08:09

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 04/04/23, 08:12

  9. Andreas Kienast merged patch set 3 04/04/23, 08:12