Review main Merged

78441[TASK] Drop superfluous codeMirror label from FormEngine elements

Andreas Kienast CR +2 V +2 Easy +0 −5 updated 04/04/23, 11:29

Commit message

The classes `T3editorElement` and `JsonElement` boot a CodeMirror
instance and provides a hard-coded label to be rendered in a panel
below the editor.

That label became useless over time as it provides redundant
information and is therefore now removed from those elements.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Andreas Kienast uploaded patch set 1 04/04/23, 10:04

  2. core-ci voted on patch set 1 V +1 04/04/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40073

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/04/23, 10:40

  4. Benni Mack voted on patch set 1 V +1 CR +1 04/04/23, 10:45

  5. Oli Bartsch commented on patch set 1 V -1 04/04/23, 10:49

    Let's drop this also in JsonElement
  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 04/04/23, 10:53

  7. Oli Bartsch uploaded patch set 3 04/04/23, 10:53

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 04/04/23, 10:54

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 04/04/23, 10:54

  10. core-ci voted on patch set 3 V +1 04/04/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40077

  11. core-ci voted on patch set 2 V +1 04/04/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40076

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 04/04/23, 11:29

  13. Oli Bartsch merged patch set 4 04/04/23, 11:29