78444[BUGFIX] Make grid selection available for Number form element
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+8 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/formEditor/editors/550.rstnew+36 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/formEditor/editors/700.rst+22 −8
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/formEditor.rst+23 −1
Review log 1012
-
Oli Bartsch uploaded patch set 1 04/04/23, 11:28
-
core-ci voted on patch set 1 V +1 04/04/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40081
-
Benni Mack commented on patch set 1 04/04/23, 15:12
Is this the same as https://review.typo3.org/c/Packages/TYPO3.CMS/+/76294 ? -
Oli Bartsch commented on patch set 1 04/04/23, 15:21
Reply
Seems so. However the patch is missing the ReST file adjustments and is also specified as TASK which is wrong. Therefore I would like to go with this patch. Do you agree? -
Jochen Roth voted on patch set 1 V +1 CR +1 04/06/23, 08:33
-
Oli Bartsch updated the commit message in patch set 2
CR +1V +104/11/23, 07:12 -
core-ci voted on patch set 2 V +1 04/11/23, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40442
-
Jochen Roth voted on patch set 2 V +1 CR +1 04/11/23, 07:57
-
Benni Mack commented on patch set 2 CR +1 04/11/23, 09:46
Reply
Done -
Andreas Kienast voted on patch set 2 V +1 CR +1 04/11/23, 11:49
-
Oli Bartsch voted on patch set 2 V +2 CR +2 04/11/23, 11:56
-
Oli Bartsch merged patch set 3 04/11/23, 11:56