Review main Merged

78444[BUGFIX] Make grid selection available for Number form element

Oli Bartsch CR +2 V +2 Normal +89 −13 updated 04/11/23, 11:56

Commit message

This fixes the YAML configuration of the "Number"
form element, making the gird selection available.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1012

  1. Oli Bartsch uploaded patch set 1 04/04/23, 11:28

  2. core-ci voted on patch set 1 V +1 04/04/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40081

  3. Benni Mack commented on patch set 1 04/04/23, 15:12

  4. Oli Bartsch commented on patch set 1 04/04/23, 15:21

    Reply

    Seems so. However the patch is missing the ReST file adjustments and is also specified as TASK which is wrong. Therefore I would like to go with this patch. Do you agree?
  5. Jochen Roth voted on patch set 1 V +1 CR +1 04/06/23, 08:33

  6. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 04/11/23, 07:12

  7. core-ci voted on patch set 2 V +1 04/11/23, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40442

  8. Jochen Roth voted on patch set 2 V +1 CR +1 04/11/23, 07:57

  9. Benni Mack commented on patch set 2 CR +1 04/11/23, 09:46

    Reply

    Done
  10. Andreas Kienast voted on patch set 2 V +1 CR +1 04/11/23, 11:49

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 04/11/23, 11:56

  12. Oli Bartsch merged patch set 3 04/11/23, 11:56